Re: Review Request 53748: Updated equals and hashCode

[Apoorv Naik <na...@gmail.com>]

> On Nov. 17, 2016, 1:37 a.m., Suma Shivaprasad wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java, line 87
> > <https://reviews.apache.org/r/53748/diff/1/?file=1563756#file1563756line87>
> >
> >     Can we switch to/think of using Lombok instead which would make the code more concise and less error prone - https://projectlombok.org/features/index.html. We could use it later for Getter/Setters and other useful features
> 
> Apoorv Naik wrote:
>     Sure I can give it a try. Is MIT licensing ok with ASF projects ?
> 
> Suma Shivaprasad wrote:
>     Yes it is compatible. Pls include the license in the LICENSE file it it doesnt exist already.

Dropping the issue for now as Madhan wants to discuss this further.


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53748/#review156164
-----------------------------------------------------------


On Nov. 29, 2016, 8:38 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53748/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 8:38 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1303
>     https://issues.apache.org/jira/browse/ATLAS-1303
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Updated equals and hashCode methods
> 
> Using JDK7's built-in classes to simplify the code and make it more readable/understandable.
> 
> 
> Diffs
> -----
> 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java b0e428f 
>   client/src/main/java/org/apache/atlas/EntityAuditEvent.java 29a04ab 
>   common/src/main/java/org/apache/atlas/ha/HAConfiguration.java aefaef5 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 5288cbf 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java d9c74ae 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 4ddd585 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java bedd4d9 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 695f1bb 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java e489f33 
>   intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java 61b7f91 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java feae00d 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 1be5ee1 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 0312176 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java f486f9b 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 16e0344 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java a3929b3 
>   notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e 
>   notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java ed5b9fc 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cdeb117 
>   typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 0b3ffe3 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java a3f9421 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeDefinition.java f556223 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 9cb0d0d 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumTypeDefinition.java ac3b5a3 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java 8069422 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/Multiplicity.java 18ef2ee 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java c9316cc 
>   webapp/src/main/java/org/apache/atlas/web/params/AbstractParam.java 9cfdb76 
> 
> Diff: https://reviews.apache.org/r/53748/diff/
> 
> 
> Testing
> -------
> 
> Working on executing all tests
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>