You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/20 17:41:46 UTC

[GitHub] [airflow] j-y-matsubara commented on a change in pull request #8867: Fixed BaseSensorOperator to make respect the trigger_rule in downstream tasks, when setting soft_fail="True"

j-y-matsubara commented on a change in pull request #8867:
URL: https://github.com/apache/airflow/pull/8867#discussion_r427765027



##########
File path: airflow/sensors/base_sensor_operator.py
##########
@@ -70,6 +72,7 @@ def __init__(self,
                  timeout: float = 60 * 60 * 24 * 7,
                  soft_fail: bool = False,
                  mode: str = 'poke',
+                 downstream_skip=None,

Review comment:
       @yuqian90 
    I agree with you.
   >We should just remove the call to _do_skip_downstream_tasks() altogether. 
   
   Indeed, when all_success trigger_rule is set, the downstream task is automatically skipped when the upstream task is skipped.
   
   I will fix it!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org