You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/17 18:10:27 UTC

[GitHub] [tvm] altanh commented on pull request #7677: [Relay][Training][Pass] Factor out first-order AD to a module pass, and add ConcretizeLike pass

altanh commented on pull request #7677:
URL: https://github.com/apache/tvm/pull/7677#issuecomment-801300223


   @comaniac thanks for the helpful feedback, it seems there's some design decisions that would be worth combining with existing approaches. I'll spend some time this week to incorporate the feedback, but in the meantime, I think I'll remove the ConcretizeLike pass from this PR and send a follow up (since the AD refactor can stand alone). How does that sound?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org