You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by pnowojski <gi...@git.apache.org> on 2017/06/28 19:07:33 UTC

[GitHub] flink pull request #4213: [FLINK-7032] Overwrite inherited properties from p...

GitHub user pnowojski opened a pull request:

    https://github.com/apache/flink/pull/4213

    [FLINK-7032] Overwrite inherited properties from parent pom

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pnowojski/flink java17

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4213
    
----
commit 257fc92a98dc1d28014bccc9bb3171e9a38062ab
Author: Piotr Nowojski <pi...@gmail.com>
Date:   2017-06-28T18:30:08Z

    [FLINK-7032] Overwrite inherited properties from parent pom
    
    Default values for compiler version are 1.6 and were causing Intellij to
    constantly switch language level to 1.6, which in turn was causing
    compilation errors. It worked fine for compiling from console using
    maven, because those values are separetly set in maven-compiler-plugin
    configuration.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

Posted by greghogan <gi...@git.apache.org>.

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/4213
  
    Are you using the Maven bundled with IntelliJ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

Posted by uce <gi...@git.apache.org>.

Github user uce commented on the issue:

    https://github.com/apache/flink/pull/4213
  
    Just ran into this as well. This was so annoying. Thank you very much for the fix... I spent an hour assuming it was a problem on my side. Merging now...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

Posted by pnowojski <gi...@git.apache.org>.

Github user pnowojski commented on the issue:

    https://github.com/apache/flink/pull/4213
  
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

Posted by pnowojski <gi...@git.apache.org>.

Github user pnowojski commented on the issue:

    https://github.com/apache/flink/pull/4213
  
    I have added one more sentence to the comment inside the pom. @zentol commit message is already quite verbose, but I have improved commit title.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/4213
  
    I also observed this after I did a fresh import on Flink in the most recent IntelliJ.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/4213
  
    Ok, now we have to many committers on this. 😅 
    
    How will merge?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

Posted by StefanRRichter <gi...@git.apache.org>.

Github user StefanRRichter commented on the issue:

    https://github.com/apache/flink/pull/4213
  
    I observed similar problems as @pnowojski and the fix helped for me, so +1 from my side.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4213
  
    @aljoscha you merge since you asked first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4213
  
    let's improve the commit message and comment in the pom as to what we're actually doing (overwriting compiler version properties) and why (IntelliJ switching back).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

Posted by greghogan <gi...@git.apache.org>.

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/4213
  
    LGTM thanks for the PR @pnowojski and for confirming the issue @StefanRRichter and @aljoscha


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

Posted by greghogan <gi...@git.apache.org>.

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/4213
  
    Okay, I am using the latest stable release (2017.1.4) and the bundled version is 3.3.9. Perhaps different versions are shipped for different OS.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4213: [FLINK-7032] Overwrite inherited properties from parent p...

Posted by pnowojski <gi...@git.apache.org>.

Github user pnowojski commented on the issue:

    https://github.com/apache/flink/pull/4213
  
    I have the latest version of the Intellij (build in June), and it uses bundled Maven 3.5.9, while my local maven is 3.5.0. For me it replicates 100% times. Touch the pom.xml of some module (by some rebase for example) and Intellij on auto import will switch it back to 1.6. Same happens if I manually click to reimport the maven module. 
    
    I know that at least @StefanRRichter had experienced the same symptoms, modules/projects randomly switching back to Java 1.6 and he didn't know why. Hopefully this fix would solve his issue. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---