You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/31 13:36:12 UTC

[GitHub] [arrow-datafusion] alamb commented on pull request #1510: Add factorial function

alamb commented on pull request #1510:
URL: https://github.com/apache/arrow-datafusion/pull/1510#issuecomment-1003378885


   > Btw there is one thing I wasn't very happy about and it is the fact that the current implementation takes only f64 but I am not sure if we want to also allow integers as possible input. Anyway, let me know what you think @Jimexist ! Thanks!
   
   It might be good to check out `sqrt` which has a similar pattern (the implementation takes `f64` but the coercion logic will  convert integer arguments to floats )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org