[jira] [Commented] (HBASE-7383) create integration test for HBASE-5416 (improving scan performance for certain filters)

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-7383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547061#comment-13547061 ] 

Ted Yu commented on HBASE-7383:
-------------------------------

{code}
+   * Generates a deterministic, unique hashed key for a number, so the user can only keep
+   * track of numbers.
{code}
Remove 'only' above.
{code}
+   * @param keyBase Base number for a key, such as a loop counter.
+   */
+  public abstract byte[] getDeterministicUniqueKey(long keyBase);
{code}
Add javadoc for @return. Same for other methods in LoadTestDataGenerator.
{code}
+  public abstract boolean verify(byte[] rowKey, byte[] cf, Set<byte[]> columnSet);
{code}
generateColumnsForCf() returns byte[][], but Set<byte[]> is passed as param above. Can you explain why the difference ?

For LoadTestKVGenerator:
{code}
+    Random seededRandom = new Random(seed);
{code}
Please use SecureRandom instead.
                
> create integration test for HBASE-5416 (improving scan performance for certain filters)
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-7383
>                 URL: https://issues.apache.org/jira/browse/HBASE-7383
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HBASE-7383-v0.patch, HBASE-7383-v1.patch, HBASE-7383-v1.patch
>
>
> HBASE-5416 is risky and needs an integration test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira