You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/19 15:53:16 UTC
[GitHub] [airflow] coopergillan opened a new pull request #7468:
[AIRFLOW-6721] Organize hive tests
coopergillan opened a new pull request #7468: [AIRFLOW-6721] Organize hive tests
URL: https://github.com/apache/airflow/pull/7468
## BEST REVIEWED COMMIT-BY-COMMIT
### Problem
Currently many different sensors and operators are tested in the Hive operators module. Some of these operators already have test modules and others do not. This was [originally called out by @mik-lag](https://github.com/apache/airflow/pull/7316#issuecomment-580946162) in #7316.
### Solution
- Move non-operator tests into separate test modules, creating new ones as needed.
- Create a shared `TestHiveEnvironment` class from `unittest.TestCase` that each of the test modules can use
- Preserve existing test functionality and skipping when adding tests to existing modules
- Update test names when being added to a more general module like `test_sql_sensor.py`
---
Issue link: [AIRFLOW-6721](https://issues.apache.org/jira/browse/AIRFLOW-6721)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7468: [AIRFLOW-6721]
Organize hive tests
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7468: [AIRFLOW-6721] Organize hive tests
URL: https://github.com/apache/airflow/pull/7468#issuecomment-588327386
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7468?src=pr&el=h1) Report
> Merging [#7468](https://codecov.io/gh/apache/airflow/pull/7468?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/3e5d272fcb9fefe35760590a767ba27be4d27665?src=pr&el=desc) will **decrease** coverage by `0.45%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7468?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7468 +/- ##
==========================================
- Coverage 86.68% 86.22% -0.46%
==========================================
Files 882 882
Lines 41526 41526
==========================================
- Hits 35997 35806 -191
- Misses 5529 5720 +191
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7468?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7468/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0%> (-64.16%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7468/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7468/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7468/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==) | `30.43% <0%> (-45.66%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7468/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
| [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7468/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `55% <0%> (-45%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7468/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.38% <0%> (-25.52%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7468/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [airflow/providers/apache/hive/hooks/hive.py](https://codecov.io/gh/apache/airflow/pull/7468/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvaG9va3MvaGl2ZS5weQ==) | `76.02% <0%> (-1.54%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7468/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `90.9% <0%> (-0.83%)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/airflow/pull/7468/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7468?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7468?src=pr&el=footer). Last update [3e5d272...edc415d](https://codecov.io/gh/apache/airflow/pull/7468?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7468: [AIRFLOW-6721] Organize
hive tests
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7468: [AIRFLOW-6721] Organize hive tests
URL: https://github.com/apache/airflow/pull/7468#issuecomment-588458850
Can you create a ticket about `AIRFLOW_RUNALL_TESTS ` environment variable? This should be replaced by pytest markers.
More information: https://github.com/apache/airflow/blob/master/TESTING.rst#airflow-integration-tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj merged pull request #7468: [AIRFLOW-6721]
Organize hive tests
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #7468: [AIRFLOW-6721] Organize hive tests
URL: https://github.com/apache/airflow/pull/7468
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] coopergillan commented on issue #7468: [AIRFLOW-6721]
Organize hive tests
Posted by GitBox <gi...@apache.org>.
coopergillan commented on issue #7468: [AIRFLOW-6721] Organize hive tests
URL: https://github.com/apache/airflow/pull/7468#issuecomment-588474051
@mik-laj - Done! https://issues.apache.org/jira/browse/AIRFLOW-6847
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services