You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "hanahmily (via GitHub)" <gi...@apache.org> on 2023/05/07 00:19:58 UTC
[GitHub] [skywalking-banyandb] hanahmily opened a new pull request, #270: Refine load testing issues and optimize performance
hanahmily opened a new pull request, #270:
URL: https://github.com/apache/skywalking-banyandb/pull/270
* Fix iterator leaks and ensure proper closure
* Introduce a closer to guarantee all iterators are closed
* Set KV's minimum memtable size to 8MB
* Enhance meter performance
* Reduce logger creation frequency
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] wu-sheng merged pull request #270: Refine load testing issues and optimize performance
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #270:
URL: https://github.com/apache/skywalking-banyandb/pull/270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] codecov-commenter commented on pull request #270: Refine load testing issues and optimize performance
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #270:
URL: https://github.com/apache/skywalking-banyandb/pull/270#issuecomment-1537254935
## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/270?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#270](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/270?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3650c0) into [main](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/236d72e9fcbfe67d169ca8db3f163fc1df809c53?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (236d72e) will **increase** coverage by `0.10%`.
> The diff coverage is `54.09%`.
```diff
@@ Coverage Diff @@
## main #270 +/- ##
==========================================
+ Coverage 46.41% 46.51% +0.10%
==========================================
Files 89 89
Lines 9292 9315 +23
==========================================
+ Hits 4313 4333 +20
- Misses 4574 4577 +3
Partials 405 405
```
| [Impacted Files](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [banyand/measure/measure\_write.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC9tZWFzdXJlL21lYXN1cmVfd3JpdGUuZ28=) | `3.87% <0.00%> (ø)` | |
| [banyand/tsdb/shard.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC90c2RiL3NoYXJkLmdv) | `55.38% <ø> (ø)` | |
| [.../query/logical/measure/measure\_plan\_aggregation.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3F1ZXJ5L2xvZ2ljYWwvbWVhc3VyZS9tZWFzdXJlX3BsYW5fYWdncmVnYXRpb24uZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/query/logical/measure/measure\_plan\_groupby.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3F1ZXJ5L2xvZ2ljYWwvbWVhc3VyZS9tZWFzdXJlX3BsYW5fZ3JvdXBieS5nbw==) | `0.00% <0.00%> (ø)` | |
| [...ry/logical/measure/measure\_plan\_indexscan\_local.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3F1ZXJ5L2xvZ2ljYWwvbWVhc3VyZS9tZWFzdXJlX3BsYW5faW5kZXhzY2FuX2xvY2FsLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/query/logical/measure/measure\_plan\_top.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3F1ZXJ5L2xvZ2ljYWwvbWVhc3VyZS9tZWFzdXJlX3BsYW5fdG9wLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/index/lsm/search.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZGV4L2xzbS9zZWFyY2guZ28=) | `49.05% <25.00%> (-2.95%)` | :arrow_down: |
| [banyand/tsdb/block.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC90c2RiL2Jsb2NrLmdv) | `54.98% <100.00%> (+1.03%)` | :arrow_up: |
| [banyand/tsdb/buffer.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC90c2RiL2J1ZmZlci5nbw==) | `86.45% <100.00%> (-1.14%)` | :arrow_down: |
| [pkg/encoding/encoder.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2VuY29kaW5nL2VuY29kZXIuZ28=) | `88.46% <100.00%> (+0.54%)` | :arrow_up: |
| ... and [2 more](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/270?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org