You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "westonpace (via GitHub)" <gi...@apache.org> on 2023/04/10 20:04:42 UTC
[GitHub] [arrow] westonpace opened a new pull request, #35016: GH-34906: [C++] Return invalid status instead of segfault if reading from a closed ArrayStreamBatchReader
westonpace opened a new pull request, #35016:
URL: https://github.com/apache/arrow/pull/35016
### Rationale for this change
Segfaults should be avoided, even on improper calling patterns.
### What changes are included in this PR?
Attempting to use a record batch reader, sourced from a C API stream, after it had been closed, will now return an invalid status instead of a segmentation fault.
### Are these changes tested?
Yes, new unit tests were added to regress this usage.
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35016: GH-34906: [C++] Return invalid status instead of segfault if reading from a closed ArrayStreamBatchReader
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35016:
URL: https://github.com/apache/arrow/pull/35016#issuecomment-1502253071
:warning: GitHub issue #34906 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35016: GH-34906: [C++] Return invalid status instead of segfault if reading from a closed ArrayStreamBatchReader
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35016:
URL: https://github.com/apache/arrow/pull/35016#issuecomment-1502253003
* Closes: #34906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche merged pull request #35016: GH-34906: [C++] Return invalid status instead of segfault if reading from a closed ArrayStreamBatchReader
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche merged PR #35016:
URL: https://github.com/apache/arrow/pull/35016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35016: GH-34906: [C++] Return invalid status instead of segfault if reading from a closed ArrayStreamBatchReader
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35016:
URL: https://github.com/apache/arrow/pull/35016#issuecomment-1504220061
Benchmark runs are scheduled for baseline = 053acabdc426606d74e10911d4f183c0b88d3fb9 and contender = b9aec9ad2b655817b8925462e4e2dd6973807e23. b9aec9ad2b655817b8925462e4e2dd6973807e23 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/81248baa7dd2458aad932c92d0ead687...ed3e55051b05435687448790bfa228af/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/1fa357c5394343a0811ce405b6132753...2de29b38fed749348c2ce415fcfa258f/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b31629a47fdb4f459ad5b934c80593e1...0bdf220883c34a7095b6f4a4ba5ff0a6/)
[Finished :arrow_down:0.43% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/35a8edd6b8e8449da7fed1596cae826a...0a1c63188bfb4e9e911eddaf02ea2fac/)
Buildkite builds:
[Finished] [`b9aec9ad` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2673)
[Failed] [`b9aec9ad` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2706)
[Finished] [`b9aec9ad` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2671)
[Finished] [`b9aec9ad` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2697)
[Finished] [`053acabd` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2672)
[Failed] [`053acabd` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2705)
[Finished] [`053acabd` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2670)
[Finished] [`053acabd` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2696)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org