You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2025/09/24 16:22:29 UTC
Re: [PR] feat: do not fallback to Spark for `COUNT(distinct)` [datafusion-comet]
andygrove commented on code in PR #2429:
URL: https://github.com/apache/datafusion-comet/pull/2429#discussion_r2376349117
##########
spark/src/test/scala/org/apache/comet/exec/CometExecSuite.scala:
##########
@@ -1031,9 +1031,6 @@ class CometExecSuite extends CometTestBase {
|GROUP BY key
""".stripMargin)
- // The above query uses COUNT(DISTINCT) which Comet doesn't support yet, so the plan will
- // have a mix of `HashAggregate` and `CometHashAggregate`. In the following we check all
- // operators starting from `CometHashAggregate` are native.
checkSparkAnswer(df)
Review Comment:
Can this change to check for Comet operators now?
```suggestion
checkSparkAnswerAndOperator(df)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org