You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/04/23 22:30:37 UTC
[GitHub] [lucene] jtibshirani commented on a change in pull request #104: LUCENE-9908: Move VectorValues#search to LeafReader
jtibshirani commented on a change in pull request #104:
URL: https://github.com/apache/lucene/pull/104#discussion_r619525800
##########
File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90VectorReader.java
##########
@@ -199,40 +229,53 @@ public void checkIntegrity() throws IOException {
@Override
public VectorValues getVectorValues(String field) throws IOException {
- FieldInfo info = fieldInfos.fieldInfo(field);
- if (info == null) {
+ FieldEntry fieldEntry = fields.get(field);
Review comment:
Across the different reader implementations, we aren't that consistent when we return `null` vs. empty. For now I just matched the current pattern in each reader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org