You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by as...@apache.org on 2006/10/02 19:16:38 UTC
svn commit: r452129 - in /cocoon/trunk/blocks/cocoon-mail: cocoon-mail-impl/
cocoon-mail-impl/src/main/java/org/apache/cocoon/mail/transformation/
cocoon-mail-sample/src/main/resources/COB-INF/mail/docs/mid-col-2/
Author: asavory
Date: Mon Oct 2 10:16:37 2006
New Revision: 452129
URL: http://svn.apache.org/viewvc?view=rev&rev=452129
Log:
Apply COCOON-1818 patch
Modified:
cocoon/trunk/blocks/cocoon-mail/cocoon-mail-impl/src/main/java/org/apache/cocoon/mail/transformation/SendMailTransformer.java
cocoon/trunk/blocks/cocoon-mail/cocoon-mail-impl/status.xml
cocoon/trunk/blocks/cocoon-mail/cocoon-mail-sample/src/main/resources/COB-INF/mail/docs/mid-col-2/mail-action.xml
Modified: cocoon/trunk/blocks/cocoon-mail/cocoon-mail-impl/src/main/java/org/apache/cocoon/mail/transformation/SendMailTransformer.java
URL: http://svn.apache.org/viewvc/cocoon/trunk/blocks/cocoon-mail/cocoon-mail-impl/src/main/java/org/apache/cocoon/mail/transformation/SendMailTransformer.java?view=diff&rev=452129&r1=452128&r2=452129
==============================================================================
--- cocoon/trunk/blocks/cocoon-mail/cocoon-mail-impl/src/main/java/org/apache/cocoon/mail/transformation/SendMailTransformer.java (original)
+++ cocoon/trunk/blocks/cocoon-mail/cocoon-mail-impl/src/main/java/org/apache/cocoon/mail/transformation/SendMailTransformer.java Mon Oct 2 10:16:37 2006
@@ -451,8 +451,10 @@
/**
*
*/
- private void sendMail() {
+ private void sendMail() throws SAXException {
try {
+ this.ignoreHooksCount++;
+ super.sendStartElementEventNS(ELEMENT_RESULT);
Properties props = new Properties();
props.put("mail.smtp.host", this.mailHost);
props.put("mail.smtp.port", String.valueOf(this.mailPort));
@@ -481,9 +483,6 @@
this.smtpMessage = setUpMessage(session);
- this.ignoreHooksCount++;
- super.sendStartElementEventNS(ELEMENT_RESULT);
-
if (this.sendPartial) {
for (int i = 0; i < this.toAddresses.size(); i++) {
List v = new ArrayList(1);
@@ -495,12 +494,16 @@
}
trans.close();
- super.sendEndElementEventNS(ELEMENT_RESULT);
- this.ignoreHooksCount--;
+ } catch (SAXException e){
+ throw e;
} catch (Exception e) {
getLogger().error("Exception sending mail", e);
sendExceptionElement(e);
}
+ finally {
+ super.sendEndElementEventNS(ELEMENT_RESULT);
+ this.ignoreHooksCount--;
+ }
}
/**
@@ -511,13 +514,12 @@
throws Exception {
AddressHandler[] iA = new AddressHandler[newAddresses.size()];
- for (int i = 0; i < newAddresses.size(); i++) {
- InternetAddress inA = new InternetAddress((String) newAddresses.get(i));
- iA[i] = new AddressHandler(inA);
- }
-
try {
- InternetAddress[] iaArr = SendMailTransformer.getAddresses(iA);
+ for (int i = 0; i < newAddresses.size(); i++) {
+ InternetAddress inA = new InternetAddress((String) newAddresses.get(i));
+ iA[i] = new AddressHandler(inA);
+ }
+ InternetAddress[] iaArr = SendMailTransformer.getAddresses(iA);
this.smtpMessage.setRecipients(Message.RecipientType.TO, iaArr);
trans.sendMessage(this.smtpMessage, iaArr);
} catch (SendFailedException e) {
Modified: cocoon/trunk/blocks/cocoon-mail/cocoon-mail-impl/status.xml
URL: http://svn.apache.org/viewvc/cocoon/trunk/blocks/cocoon-mail/cocoon-mail-impl/status.xml?view=diff&rev=452129&r1=452128&r2=452129
==============================================================================
--- cocoon/trunk/blocks/cocoon-mail/cocoon-mail-impl/status.xml (original)
+++ cocoon/trunk/blocks/cocoon-mail/cocoon-mail-impl/status.xml Mon Oct 2 10:16:37 2006
@@ -66,6 +66,9 @@
<!-- The following list contains the changes since the latest 2.1.x version. -->
<changes>
<release version="@version@" date="@date@">
+ <action dev="AS" type="fix" fixes-bug="COCOON-1818" due-to="Jasha Joachimsthal">
+ Apply patch to handle malformed recipient address exception correctly.
+ </action>
<action dev="UH" type="add" due-to="Johan Stuyts">
The SendMailTransformer can now configure the smtp port.
</action>
Modified: cocoon/trunk/blocks/cocoon-mail/cocoon-mail-sample/src/main/resources/COB-INF/mail/docs/mid-col-2/mail-action.xml
URL: http://svn.apache.org/viewvc/cocoon/trunk/blocks/cocoon-mail/cocoon-mail-sample/src/main/resources/COB-INF/mail/docs/mid-col-2/mail-action.xml?view=diff&rev=452129&r1=452128&r2=452129
==============================================================================
--- cocoon/trunk/blocks/cocoon-mail/cocoon-mail-sample/src/main/resources/COB-INF/mail/docs/mid-col-2/mail-action.xml (original)
+++ cocoon/trunk/blocks/cocoon-mail/cocoon-mail-sample/src/main/resources/COB-INF/mail/docs/mid-col-2/mail-action.xml Mon Oct 2 10:16:37 2006
@@ -104,7 +104,7 @@
</map:action>
<!-- access javamail objects -->
- <map:generator type="serverpages" src="docs/{1}.xsp"/>
+ <map:generate type="serverpages" src="docs/{1}.xsp"/>
<map:transform src="stylesheets/mail2html.xsl"/>
<map:transform type="html"/>
</map:match>