You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/02/27 14:56:20 UTC
[GitHub] [ignite] nizhikov opened a new pull request #7479: IGNITE-12723:
getMXBean for tests introduced.
nizhikov opened a new pull request #7479: IGNITE-12723: getMXBean for tests introduced.
URL: https://github.com/apache/ignite/pull/7479
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] nizhikov commented on issue #7479: IGNITE-12723: getMXBean
for tests introduced.
Posted by GitBox <gi...@apache.org>.
nizhikov commented on issue #7479: IGNITE-12723: getMXBean for tests introduced.
URL: https://github.com/apache/ignite/pull/7479#issuecomment-593319258
> Better name might be ‘metricMXBean’
Got it. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] nizhikov commented on issue #7479: IGNITE-12723: getMXBean
for tests introduced.
Posted by GitBox <gi...@apache.org>.
nizhikov commented on issue #7479: IGNITE-12723: getMXBean for tests introduced.
URL: https://github.com/apache/ignite/pull/7479#issuecomment-593225141
@Vladsz83 Thanks for the review
> Should we slightly rename GridAbstractTest#metricRegistry()?
Rename of the existing methods is not the goal of this ticket.
What name is more convenient?
> Do we need to keep
Yes. These methods used multiple times, so I think it OK to keep them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] nizhikov merged pull request #7479: IGNITE-12723:
getMXBean for tests introduced.
Posted by GitBox <gi...@apache.org>.
nizhikov merged pull request #7479: IGNITE-12723: getMXBean for tests introduced.
URL: https://github.com/apache/ignite/pull/7479
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] Vladsz83 commented on issue #7479: IGNITE-12723: getMXBean
for tests introduced.
Posted by GitBox <gi...@apache.org>.
Vladsz83 commented on issue #7479: IGNITE-12723: getMXBean for tests introduced.
URL: https://github.com/apache/ignite/pull/7479#issuecomment-593121025
@nizhikov ,
1) Should we slightly rename `GridAbstractTest#metricRegistry()`?
2) Do we need to keep `CacheMetricsManageTest#mxBean()` `ClusterBaselineNodesMetricsSelfTest#mxBean()`, `GridCacheLongRunningTransactionDiagnosticsTest#txMXBean()`, `SetTxTimeoutOnPartitionMapExchangeTest#txMXBean()`, `TcpCommunicationStatisticsTest#mbean()`? Why not using `GridAbstractTest#getMxBean()` directly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] Vladsz83 commented on issue #7479: IGNITE-12723: getMXBean
for tests introduced.
Posted by GitBox <gi...@apache.org>.
Vladsz83 commented on issue #7479: IGNITE-12723: getMXBean for tests introduced.
URL: https://github.com/apache/ignite/pull/7479#issuecomment-593317289
@nizhikov ,
>>> What name is more convenient?
I was confused with 'metric registry' and dynamic mbeans, dynamic mbean creation. The method is about dynamic mbean to show some numbers, but not exactly for a metric registry . Better name might be ‘metricMXBean’
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services