[GitHub] [tvm] ashutosh-arm commented on a diff in pull request #11701: [CMSIS-NN] Fixed error in finding input's dtype in maxpool

[GitBox <gi...@apache.org>]

ashutosh-arm commented on code in PR #11701:
URL: https://github.com/apache/tvm/pull/11701#discussion_r897745393


##########
tests/python/contrib/test_cmsisnn/test_pooling.py:
##########
@@ -45,11 +45,15 @@ def make_model(
     zero_point=-33,
     relu_type="RELU",
     layout="NHWC",
+    input_op=None,

Review Comment:
   The model creator always starts with an input var: https://github.com/apache/tvm/blob/3eb372e26fc3797150ddc7a0ab96871725af4d1d/tests/python/contrib/test_cmsisnn/test_pooling.py#L52, but in our case we want to pass on our own input node to the model.



##########
python/tvm/relay/op/contrib/cmsisnn.py:
##########
@@ -206,17 +206,17 @@ def qnn_avg_pool2d_pattern():
     def check_qnn_avg_pool2d(pattern):
         """Check if avg pool2d is supported by CMSIS-NN."""
         output = pattern
-        input_var = _find_last(pattern)

Review Comment:
   ACK



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org