You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/11/24 11:25:54 UTC
[kudu-CR] Make DebugDumpCompactionInput use CompactionInputRowToString
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5215
Change subject: Make DebugDumpCompactionInput use CompactionInputRowToString
......................................................................
Make DebugDumpCompactionInput use CompactionInputRowToString
Recent patches changed and unified the way we print rows but this
method was left out as multiple tests were depending on the old format.
This patch takes this the rest of the way and changes the tests so
that they use the new format.
Change-Id: I13a83ecdb8f801c7952d6e130db77726f3b14a83
---
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/tablet_history_gc-test.cc
4 files changed, 63 insertions(+), 63 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/5215/1
--
To view, visit http://gerrit.cloudera.org:8080/5215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I13a83ecdb8f801c7952d6e130db77726f3b14a83
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] Make DebugDumpCompactionInput use CompactionInputRowToString
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Make DebugDumpCompactionInput use CompactionInputRowToString
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I13a83ecdb8f801c7952d6e130db77726f3b14a83
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Make DebugDumpCompactionInput use CompactionInputRowToString
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Make DebugDumpCompactionInput use CompactionInputRowToString
......................................................................
Make DebugDumpCompactionInput use CompactionInputRowToString
Recent patches changed and unified the way we print rows but this
method was left out as multiple tests were depending on the old format.
This patch takes this the rest of the way and changes the tests so
that they use the new format.
Change-Id: I13a83ecdb8f801c7952d6e130db77726f3b14a83
Reviewed-on: http://gerrit.cloudera.org:8080/5215
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/tablet_history_gc-test.cc
4 files changed, 58 insertions(+), 59 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I13a83ecdb8f801c7952d6e130db77726f3b14a83
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Make DebugDumpCompactionInput use CompactionInputRowToString
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Make DebugDumpCompactionInput use CompactionInputRowToString
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I13a83ecdb8f801c7952d6e130db77726f3b14a83
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Make DebugDumpCompactionInput use CompactionInputRowToString
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Make DebugDumpCompactionInput use CompactionInputRowToString
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I13a83ecdb8f801c7952d6e130db77726f3b14a83
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Make DebugDumpCompactionInput use CompactionInputRowToString
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5215
to look at the new patch set (#2).
Change subject: Make DebugDumpCompactionInput use CompactionInputRowToString
......................................................................
Make DebugDumpCompactionInput use CompactionInputRowToString
Recent patches changed and unified the way we print rows but this
method was left out as multiple tests were depending on the old format.
This patch takes this the rest of the way and changes the tests so
that they use the new format.
Change-Id: I13a83ecdb8f801c7952d6e130db77726f3b14a83
---
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/tablet_history_gc-test.cc
4 files changed, 58 insertions(+), 59 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/5215/2
--
To view, visit http://gerrit.cloudera.org:8080/5215
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I13a83ecdb8f801c7952d6e130db77726f3b14a83
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>