You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@drill.apache.org by ts...@apache.org on 2015/05/17 08:51:26 UTC

[06/26] drill git commit: Jason's review

Jason's review


Project: http://git-wip-us.apache.org/repos/asf/drill/repo
Commit: http://git-wip-us.apache.org/repos/asf/drill/commit/10e158f8
Tree: http://git-wip-us.apache.org/repos/asf/drill/tree/10e158f8
Diff: http://git-wip-us.apache.org/repos/asf/drill/diff/10e158f8

Branch: refs/heads/gh-pages
Commit: 10e158f886e614f9855b648772ef6d46ac5ecd23
Parents: f58d360
Author: Kristine Hahn <kh...@maprtech.com>
Authored: Thu May 14 15:28:07 2015 -0700
Committer: Kristine Hahn <kh...@maprtech.com>
Committed: Thu May 14 15:28:07 2015 -0700

----------------------------------------------------------------------
 _docs/data-sources-and-file-formats/050-json-data-model.md | 4 ++--
 _docs/sql-reference/data-types/010-supported-data-types.md | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/drill/blob/10e158f8/_docs/data-sources-and-file-formats/050-json-data-model.md
----------------------------------------------------------------------
diff --git a/_docs/data-sources-and-file-formats/050-json-data-model.md b/_docs/data-sources-and-file-formats/050-json-data-model.md
index 82b8a3a..0e8b0d3 100644
--- a/_docs/data-sources-and-file-formats/050-json-data-model.md
+++ b/_docs/data-sources-and-file-formats/050-json-data-model.md
@@ -40,9 +40,9 @@ The following table shows SQL-JSON data type mapping:
 By default, Drill does not support JSON lists of different types. For example, JSON does not enforce types or distinguish between integers and floating point values. When reading numerical values from a JSON file, Drill distinguishes integers from floating point numbers by the presence or lack of a decimal point. If some numbers in a JSON map or array appear with and without a decimal point, such as 0 and 0.0, Drill throws a schema change error. You use the following options to read JSON lists of different types:
 
 * `store.json.read_numbers_as_double`  
-  Reads numbers from JSON files with or without a decimal point as DOUBLE. You need to cast numbers from VARCHAR to numerical data types, such as DOUBLE or INTEGER.
+  Reads numbers from JSON files with or without a decimal point as DOUBLE. You need to cast numbers from DOUBLE to other numerical types only if you cannot use the numbers as DOUBLE.
 * `store.json.all_text_mode`  
-  Reads all data from JSON files as VARCHAR. you need to cast numbers from DOUBLE to other numerical types only if you cannot use the numbers as DOUBLE.
+  Reads all data from JSON files as VARCHAR. You need to cast numbers from VARCHAR to numerical data types, such as DOUBLE or INTEGER.
 
 The default setting of `store.json.all_text_mode` and `store.json.read_numbers_as_double` options is false. Using either option prevents schema errors, but using `store.json.read_numbers_as_double` has an advantage over `store.json.all_text_mode`. Using `store.json.read_numbers_as_double` typically involves less explicit casting than using `store.json.all_text_mode` because you can often use the numerical data as is -\-DOUBLE.
 

http://git-wip-us.apache.org/repos/asf/drill/blob/10e158f8/_docs/sql-reference/data-types/010-supported-data-types.md
----------------------------------------------------------------------
diff --git a/_docs/sql-reference/data-types/010-supported-data-types.md b/_docs/sql-reference/data-types/010-supported-data-types.md
index c588a8b..5d7fa86 100644
--- a/_docs/sql-reference/data-types/010-supported-data-types.md
+++ b/_docs/sql-reference/data-types/010-supported-data-types.md
@@ -22,7 +22,7 @@ Drill reads from and writes to data sources having a wide variety of types. Dril
 | CHARACTER VARYING, CHARACTER, CHAR, or VARCHAR*** | UTF8-encoded variable-length string. The default limit is 1 character. The maximum character limit is 2,147,483,647. | CHAR(30) casts data to a 30-character string maximum.                          |
 
 
-\* In this release, Drill disables the DECIMAL data type, including casting to DECIMAL and reading DECIMAL types from Parquet and Hive. The NUMERIC data type is an alias for the DECIMAL data type.
+\* In this release, Drill disables the DECIMAL data type, including casting to DECIMAL and reading DECIMAL types from Parquet and Hive. The NUMERIC data type is an alias for the DECIMAL data type.  
 \*\* Not currently supported.  
 \*\*\* Currently, Drill supports only variable-length strings.