You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Gourab Taparia (Jira)" <ji...@apache.org> on 2022/11/28 08:18:00 UTC
[jira] [Updated] (PHOENIX-6839) Rename ExecutableXXXStatement classes to CompilableXXXStatement to correctly name Compilable classes.
[ https://issues.apache.org/jira/browse/PHOENIX-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gourab Taparia updated PHOENIX-6839:
------------------------------------
Description:
In the PhoenixStatement implementation there are various subclasses denoting various statements. For various implementations of CompilableStatements, it is seen that the underlying class is named prefixed with Executable (for e.g. ExecutableSelectStatement). This is confusing and makes the code readability harder.
For e.g. Below is the declaration for ExecutableSelectStatement - [code|https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java#L665]
{code:java}
private static class ExecutableSelectStatement extends SelectStatement implements CompilableStatement {code}
This is there for other Statements too, ExecutableCloseStatement , ExecutableCreateTableStatement to name a few. We should fix all the related class declaration with this.
[~kadir] had mentioned this in one of the offline syncs. Logging this here for any improvement.
was:
In the PhoenixStatement implementation there are various subclasses denoting various statements. For various implementations of CompilableStatements, it is seen that the underlying class is named prefixed with Executable (for e.g. ExecutableSelectStatement). This is confusing and makes the code readability harder.
For e.g. Below is the declaration for ExecutableSelectStatement - [code|https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java#L665]
{code:java}
private static class ExecutableSelectStatement extends SelectStatement implements CompilableStatement {code}
This is there for other Statements too, ExecutableCloseStatement , ExecutableCreateTableStatement to name a few. We should fix all the related class declaration with this.
> Rename ExecutableXXXStatement classes to CompilableXXXStatement to correctly name Compilable classes.
> -----------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6839
> URL: https://issues.apache.org/jira/browse/PHOENIX-6839
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Affects Versions: 4.14.1, 4.16.1, 5.1.2
> Reporter: Gourab Taparia
> Priority: Minor
>
> In the PhoenixStatement implementation there are various subclasses denoting various statements. For various implementations of CompilableStatements, it is seen that the underlying class is named prefixed with Executable (for e.g. ExecutableSelectStatement). This is confusing and makes the code readability harder.
> For e.g. Below is the declaration for ExecutableSelectStatement - [code|https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java#L665]
> {code:java}
> private static class ExecutableSelectStatement extends SelectStatement implements CompilableStatement {code}
>
> This is there for other Statements too, ExecutableCloseStatement , ExecutableCreateTableStatement to name a few. We should fix all the related class declaration with this.
> [~kadir] had mentioned this in one of the offline syncs. Logging this here for any improvement.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)