[GitHub] [netbeans] phejl commented on a change in pull request #2835: Opt-in to treat warnings as errors

[GitBox <gi...@apache.org>]

phejl commented on a change in pull request #2835:
URL: https://github.com/apache/netbeans/pull/2835#discussion_r605013017



##########
File path: platform/api.annotations.common/build.xml
##########
@@ -24,79 +24,4 @@
 
     <import file="../../nbbuild/templates/projectized.xml"/>
 
-    <!--
-    <target name="findbugs-annotations-init" if="api.annotations.common.findbugs">
-        <echo>Building common annotations for usage with FindBugs...</echo>
-
-        <property name="src.dir" location="build/generated"/>
-        <property name="src.common" location="src"/>
-
-    </target>
-
-    <target name="build-init" depends="findbugs-annotations-init, projectized.build-init"/>
-
-    <target name="compile" depends="findbugs-annotations, projectized-common.compile"/>
-
-    <target name="findbugs-annotations" if="api.annotations.common.findbugs" depends="build-init, projectized.findbugs-init">

Review comment:
       It's been a long time so I don't remember exactly (and I'm not sure where this might have evolved) but this was present to change annotations to class retention and thus usable in FindBugs/SpotBugs check as it operates on class files.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists