You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by thomastechs <gi...@git.apache.org> on 2016/03/02 06:54:17 UTC
[GitHub] spark pull request: [SPARK-12941][SQL][MASTER] Spark-SQL JDBC Orac...
GitHub user thomastechs opened a pull request:
https://github.com/apache/spark/pull/11462
[SPARK-12941][SQL][MASTER] Spark-SQL JDBC Oracle dialect fails to map string datatypes to Oracle VARCHAR datatype
## What changes were proposed in this pull request?
Added a test suite for the oracle type mapping corresponding to the type StringType
## How was this patch tested?
Tested manually, using the test suite
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thomastechs/spark branch-12941-for-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11462.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11462
----
commit cb2d5b3e84fc96002b8b113142b90a71103f66cd
Author: thomastechs <th...@tcs.com>
Date: 2016-02-22T17:24:15Z
Update pom.xml for [SPARK-12941] docker test suite addition
Updated pom.xml for the OracleIntegrationSuite created for the bug fix [SPARK-12941] ,adding dependency on the ojdbc jar
commit 0722efb58fa7e8b283dce2adc28b35c4fe0f53b8
Author: thomastechs <th...@tcs.com>
Date: 2016-02-22T17:28:33Z
Update OracleDialect.scala for [SPARK-12941] docker test suite addition
Updated the OracleDialect.scala with the corresponding change for the bug fix [SPARK-12941] for master branch
commit d8d9488c453cf175c48e712219fff0a2327d6832
Author: thomastechs <th...@tcs.com>
Date: 2016-02-22T17:31:00Z
Update DockerJDBCIntegrationSuite.scala for [SPARK-12941] docker test suite addition
Updated this file with the timeout interval to 200 to incorporate the Oracle docker testing, which was verified that, it required such a time interval of 200 sec to get the Oracle instance to be up in the container.
commit dbc33a6e998c9b61109fee27d04f882333718067
Author: thomastechs <th...@tcs.com>
Date: 2016-03-02T05:51:28Z
Update JDBCSuite.scala [SPARK-12941][Master]
Updated this file with the test suite for the Oracle type mapping corresponding to the StringType as per the bug reported in
SPARK-12941
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-**][SQL][MASTER] Added-TestSuite :Spark...
Posted by thomastechs <gi...@git.apache.org>.
Github user thomastechs commented on the pull request:
https://github.com/apache/spark/pull/11462#issuecomment-191080241
Closing this PR as unintended changes came in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-**][SQL][MASTER] Added-TestSuite :Spark...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11462#issuecomment-191080236
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-**][SQL][MASTER] Added-TestSuite :Spark...
Posted by thomastechs <gi...@git.apache.org>.
Github user thomastechs closed the pull request at:
https://github.com/apache/spark/pull/11462
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org