You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2024/02/15 16:19:44 UTC
[PR] fix: RLS modal overflow [superset]
michael-s-molina opened a new pull request, #27128:
URL: https://github.com/apache/superset/pull/27128
### SUMMARY
Fixes https://github.com/apache/superset/issues/27079 and also adjusts the description input theme.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: modal was overflowing and the description input theme was not matching other inputs
<img width="516" alt="Screenshot 2024-02-15 at 11 16 53" src="https://github.com/apache/superset/assets/70410625/7d47fd23-aec8-483b-b4fe-21a42491c999">
After: modal correctly displays a scroll when needed and the input theme is fixed
<img width="522" alt="Screenshot 2024-02-15 at 11 14 40" src="https://github.com/apache/superset/assets/70410625/cd0fce57-5fa3-4629-aec9-f9c0a2af2e63">
### TESTING INSTRUCTIONS
Check that the RLS does not overflow and that the description input theme matches other inputs..
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: RLS modal overflow [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #27128:
URL: https://github.com/apache/superset/pull/27128#issuecomment-1946550614
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27128?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `1 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`753ef69`)](https://app.codecov.io/gh/apache/superset/commit/753ef695294ce26238b68ff41ba0a9af6aea74de?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 67.16% compared to head [(`ad53482`)](https://app.codecov.io/gh/apache/superset/pull/27128?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 67.16%.
> Report is 3 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/superset/pull/27128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...rontend/src/features/rls/RowLevelSecurityModal.tsx](https://app.codecov.io/gh/apache/superset/pull/27128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL3Jscy9Sb3dMZXZlbFNlY3VyaXR5TW9kYWwudHN4) | 94.73% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset/pull/27128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #27128 +/- ##
==========================================
- Coverage 67.16% 67.16% -0.01%
==========================================
Files 1902 1902
Lines 74454 74453 -1
Branches 8304 8304
==========================================
- Hits 50009 50008 -1
Misses 22391 22391
Partials 2054 2054
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/27128/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/27128/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.85% <95.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/27128?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: RLS modal overflow [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #27128:
URL: https://github.com/apache/superset/pull/27128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: RLS modal overflow [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #27128:
URL: https://github.com/apache/superset/pull/27128#discussion_r1491274570
##########
superset-frontend/src/features/rls/RowLevelSecurityModal.tsx:
##########
@@ -155,23 +152,25 @@ function RowLevelSecurityModal(props: RowLevelSecurityModalProps) {
addDangerToast,
);
- // initialize
- useEffect(() => {
- if (!isEditMode) {
- setCurrentRule({ ...DEAFULT_RULE });
- } else if (rule?.id !== null && !loading && !fetchError) {
- fetchResource(rule.id as number);
- }
- }, [rule]);
+ const updateRuleState = (name: string, value: any) => {
Review Comment:
Just rearranging functions order to resolve warning.
##########
superset-frontend/src/features/rls/RowLevelSecurityModal.tsx:
##########
@@ -202,6 +201,24 @@ function RowLevelSecurityModal(props: RowLevelSecurityModalProps) {
return { tables, roles };
}, [resource?.tables, resource?.roles]);
+ // initialize
Review Comment:
Just rearranging functions order to resolve warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: RLS modal overflow [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #27128:
URL: https://github.com/apache/superset/pull/27128#discussion_r1491275211
##########
superset-frontend/src/features/rls/RowLevelSecurityModal.tsx:
##########
@@ -318,19 +328,6 @@ function RowLevelSecurityModal(props: RowLevelSecurityModalProps) {
[],
);
- // * state validators *
Review Comment:
Just rearranging functions order to resolve warning.
##########
superset-frontend/src/features/rls/RowLevelSecurityModal.tsx:
##########
@@ -214,13 +231,6 @@ function RowLevelSecurityModal(props: RowLevelSecurityModalProps) {
label: string;
};
- const updateRuleState = (name: string, value: any) => {
Review Comment:
Just rearranging functions order to resolve warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org