You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Szilard Nemeth (Jira)" <ji...@apache.org> on 2021/01/20 08:58:00 UTC

[jira] [Created] (YARN-10580) Fix some issues in TestRMWebServicesCapacitySchedDynamicConfig

Szilard Nemeth created YARN-10580:
-------------------------------------

             Summary: Fix some issues in TestRMWebServicesCapacitySchedDynamicConfig
                 Key: YARN-10580
                 URL: https://issues.apache.org/jira/browse/YARN-10580
             Project: Hadoop YARN
          Issue Type: Improvement
            Reporter: Szilard Nemeth


YARN-10512 introduced some changes that could be fixed, [~pbacsko] highlighted those issues with this comment.

Pasting the contents of the comment as a reference

#1 In TestRMWebServicesCapacitySchedDynamicConfig:
{noformat}
config.set(YarnConfiguration.SCHEDULER_CONFIGURATION_STORE_CLASS,
	        YarnConfiguration.MEMORY_CONFIGURATION_STORE);
{noformat}
This call is repeated multiple times, this could be set somewhere else.

 

#2 In TestRMWebServicesCapacitySchedDynamicConfig:
{noformat}
validateSchedulerInfo(json, "weight", "root.default", "root.test1", "root.test2");
{noformat}
"root.default", "root.test1" and "root.test2" are the same in all cases, you might want to drop them

 

#3 In TestRMWebServicesCapacitySchedDynamicConfig
{noformat}
          @Before
	  @Override
	  public void setUp() throws Exception {
	    super.setUp();
	  }
{noformat}
This method does nothing, can be removed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org