[GitHub] [hbase] ndimiduk commented on a diff in pull request #4319: HBASE-26929 Upgrade surefire plugin to 3.0.0-M6

[GitBox <gi...@apache.org>]

ndimiduk commented on code in PR #4319:
URL: https://github.com/apache/hbase/pull/4319#discussion_r843258772


##########
dev-support/hbase-personality.sh:
##########
@@ -500,7 +500,7 @@ function shadedjars_rebuild
 
   local -a maven_args=('clean' 'verify' '-fae' '--batch-mode'
     '-pl' 'hbase-shaded/hbase-shaded-check-invariants' '-am'
-    '-Dtest=NoUnitTests' '-DHBasePatchProcess' '-Prelease'
+    '-DskipTests' '-DHBasePatchProcess' '-Prelease'

Review Comment:
   I believe the `NoUnitTests` is intentional in that it forces the `test-compile` stage to happen even without running any tests. `-DskipTests` will bypass the whole `test` phase and so the unit test code is never compiled.



##########
pom.xml:
##########
@@ -842,7 +842,7 @@
     <findbugs-annotations.version>1.3.9-1</findbugs-annotations.version>
     <spotbugs.version>4.2.2</spotbugs.version>
     <spotbugs.maven.version>4.2.0</spotbugs.maven.version>
-    <surefire.version>3.0.0-M4</surefire.version>
+    <surefire.version>3.0.0-M6</surefire.version>

Review Comment:
   Woo! 🥳 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org