[jira] [Comment Edited] (JENA-714) Language level upgrade

["Andy Seaborne (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JENA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031531#comment-14031531 ] 

Andy Seaborne edited comment on JENA-714 at 6/14/14 10:18 AM:
--------------------------------------------------------------

Awesome.  I took a look (by sampling) and found these transformations:

1. Removing the explicit classes and using {{<>}} with {{new}}
2. Using Iterables for loops
3. Using {{StringBuilder}} in place of {{StringBuffer}}
4. switch statement and strings
5. {{catch (e1|e2)}}

Are there any others?

One minor downside is that (one in place I saw) it uses same column {} and not the Egyptian {} the code had to start with at that point but IntelliJ is probably just getting confused as Jena is patchy on this and the file might be inconsistent.  (Multiple weak policies at different times ... just the effects history.)



was (Author: andy.seaborne):
Awesome.  I took a look (by sampling) and the transformation I found included:

1. Removing the explicit classes and using {{<>}} with {{new}}
2. Using Iterables for loops
3. Using {{StringBuilder}} in place of {{StringBuffer}}
4. switch statement and strings
5. {{catch (e1|e2)}}

Any others?

One minor downside is that (on in place) it uses same column {} and not the Egyptian {} the code had to start with at that point but IntelliJ is probably just getting confused as Jena is patchy on this and the file might be inconsistent.  (Multiple weak policies at different times ... just the effects history.)


> Language level upgrade
> ----------------------
>
>                 Key: JENA-714
>                 URL: https://issues.apache.org/jira/browse/JENA-714
>             Project: Apache Jena
>          Issue Type: Improvement
>            Reporter: Kristian Rosenvold
>            Assignee: Andy Seaborne
>         Attachments: languageLevel.patch
>
>
> The enclosed patch is a result of running a large number of automated language level upgrades available in intellij Idea (about 4000 individual items). 
> As such, the patch contains no "manual" changes done by hand, and should be safe to apply, if somewhat large :)



--
This message was sent by Atlassian JIRA
(v6.2#6252)