You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/13 21:33:58 UTC
[jira] [Commented] (NIFI-3194) PutElasticsearchHttp should route
flowfiles to failure on connection errors
[ https://issues.apache.org/jira/browse/NIFI-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746330#comment-15746330 ]
ASF GitHub Bot commented on NIFI-3194:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/1327
NIFI-3194: PutElasticsearchHttp should route flowfiles to failure on connection errors
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-3194
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1327.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1327
----
commit 1eba4d5f895d35c5236a84990d29cfe3675bfc66
Author: Matt Burgess <ma...@apache.org>
Date: 2016-12-13T21:26:32Z
NIFI-3194: Unit test showing PutESHttp bug
commit 9abfdb386c7d6df3c50d3d48e1b40621459858fb
Author: Matt Burgess <ma...@apache.org>
Date: 2016-12-13T21:27:52Z
NIFI-3194: Fixed error handling in PutElasticsearchHttp
----
> PutElasticsearchHttp should route flowfiles to failure on connection errors
> ---------------------------------------------------------------------------
>
> Key: NIFI-3194
> URL: https://issues.apache.org/jira/browse/NIFI-3194
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Matt Burgess
> Assignee: Matt Burgess
>
> If PutElasticsearchHttp encounters connection errors with the specified URL (such as there is no server available at the specified hostname:port), a ProcessException is thrown and the session is rolled back.
> For other processors that accept input flow files and access a URL (such as PostHttp and InvokeHttp), if such an error occurs, the flow file(s) are routed to failure. PutElasticsearchHttp should have behavior consistent with the others, and if connection errors occur, any incoming flow files should be routed to failure.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)