You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-dev@hadoop.apache.org by "stack (JIRA)" <ji...@apache.org> on 2008/01/19 18:22:35 UTC

[jira] Created: (HADOOP-2666) [hbase] Cleanup: All generated code should go into the o.a.h.h.generated package

[hbase] Cleanup: All generated code should go into the o.a.h.h.generated package
--------------------------------------------------------------------------------

                 Key: HADOOP-2666
                 URL: https://issues.apache.org/jira/browse/HADOOP-2666
             Project: Hadoop
          Issue Type: Improvement
          Components: contrib/hbase
            Reporter: stack
            Priority: Trivial


As is, generated code goes into o.a.h.h.thrift.generated, o.a.h.h.hql.generated, etc.  Rather, have it all go into the one package, o.a.h.h.generated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: [jira] Created: (HADOOP-2666) [hbase] Cleanup: All generated code should go into the o.a.h.h.generated package

Posted by edward yoon <ed...@mail.udanax.org>.

+1, I thought it was too complicated.

On 1/20/08, stack (JIRA) <ji...@apache.org> wrote:
> [hbase] Cleanup: All generated code should go into the o.a.h.h.generated package
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-2666
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2666
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>            Reporter: stack
>            Priority: Trivial
>
>
> As is, generated code goes into o.a.h.h.thrift.generated, o.a.h.h.hql.generated, etc.  Rather, have it all go into the one package, o.a.h.h.generated.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>



-- 
B. Regards,
Edward yoon @ NHN, corp.

[jira] Commented: (HADOOP-2666) [hbase] Cleanup: All generated code should go into the o.a.h.h.generated package

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/HADOOP-2666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560733#action_12560733 ] 

Bryan Duxbury commented on HADOOP-2666:
---------------------------------------

-1 on this one. It seems like it would be a little confusing. If there's a thrift package, then the generated code for thrift should probably be under it. 

> [hbase] Cleanup: All generated code should go into the o.a.h.h.generated package
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-2666
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2666
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>            Reporter: stack
>            Priority: Trivial
>
> As is, generated code goes into o.a.h.h.thrift.generated, o.a.h.h.hql.generated, etc.  Rather, have it all go into the one package, o.a.h.h.generated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HADOOP-2666) [hbase] Cleanup: All generated code should go into the o.a.h.h.generated package

Posted by "stack (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/HADOOP-2666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560737#action_12560737 ] 

stack commented on HADOOP-2666:
-------------------------------

I should have been more explicit.  Thrift generated code would go into o.a.h.h.generated.thrift and so on.  Within the generated package there would be subpackages.  You still -1?

> [hbase] Cleanup: All generated code should go into the o.a.h.h.generated package
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-2666
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2666
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>            Reporter: stack
>            Priority: Trivial
>
> As is, generated code goes into o.a.h.h.thrift.generated, o.a.h.h.hql.generated, etc.  Rather, have it all go into the one package, o.a.h.h.generated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.