You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by "Matt McCline (JIRA)" <ji...@apache.org> on 2017/10/05 03:24:01 UTC

[jira] [Commented] (ORC-243) incorrect isRepeating handling in decimal reader

    [ https://issues.apache.org/jira/browse/ORC-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192421#comment-16192421 ] 

Matt McCline commented on ORC-243:
----------------------------------

No, that fix is no quite right.

When a ColumnVector is reset the invariant should be:

isRepeating == false
noNulls = true
isNull array all false

I think Gopal just determined that the decimal reader isn't calling reset...

> incorrect isRepeating handling in decimal reader
> ------------------------------------------------
>
>                 Key: ORC-243
>                 URL: https://issues.apache.org/jira/browse/ORC-243
>             Project: ORC
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Blocker
>         Attachments: ORC-243.patch
>
>
> This can lead to incorrect results. 
> I need to look at other readers, will do tomorrow if this looks ok in general.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)