[GitHub] [spark] gaborgsomogyi commented on a change in pull request #31154: [SPARK-34090][SS]Cache HadoopDelegationTokenManager.isServiceEnabled result used in KafkaTokenUtil.needTokenUpdate

[GitBox <gi...@apache.org>]

gaborgsomogyi commented on a change in pull request #31154:
URL: https://github.com/apache/spark/pull/31154#discussion_r555776045



##########
File path: external/kafka-0-10-token-provider/src/test/scala/org/apache/spark/kafka010/KafkaTokenUtilSuite.scala
##########
@@ -239,24 +239,17 @@ class KafkaTokenUtilSuite extends SparkFunSuite with KafkaDelegationTokenTest {
     assert(jaasParams.contains(tokenPassword1))
   }
 
-  test("needTokenUpdate without security credentials enabled should return false") {

Review comment:
       In order to help reviewers since `needTokenUpdate` behaviour changed this test doesn't make sense so removed. From now on `needTokenUpdate` can be called only when it's checked that the Kafka related delegation token provider is enabled. This happens in `KafkaDataConsumer`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org