You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/05/05 10:13:42 UTC
[GitHub] [hive] pvary opened a new pull request, #3268: HIVE-26200: Add tests for Iceberg DELETE statements for every supported type
pvary opened a new pull request, #3268:
URL: https://github.com/apache/hive/pull/3268
### What changes were proposed in this pull request?
Added a new test
### Why are the changes needed?
To make sure that the delete is working for every type of fields, and it keeps working
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Added a unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] lcspinter commented on a diff in pull request #3268: HIVE-26200: Add tests for Iceberg DELETE statements for every supported type
Posted by GitBox <gi...@apache.org>.
lcspinter commented on code in PR #3268:
URL: https://github.com/apache/hive/pull/3268#discussion_r865950953
##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergV2.java:
##########
@@ -354,6 +356,30 @@ public void testDeleteStatementWithPartitionAndSchemaEvolution() {
HiveIcebergTestUtils.validateData(expected, HiveIcebergTestUtils.valueForRow(newSchema, objects), 0);
}
+ @Test
+ public void testDeleteForSupportedTypes() throws IOException {
+ for (int i = 0; i < SUPPORTED_TYPES.size(); i++) {
+ Type type = SUPPORTED_TYPES.get(i);
+ // TODO: remove this filter when issue #1881 is resolved
+ if (type == Types.UUIDType.get() && fileFormat == FileFormat.PARQUET) {
+ continue;
+ }
+ // TODO: remove this filter when we figure out how we could test binary types
+ if (type.equals(Types.BinaryType.get()) || type.equals(Types.FixedType.ofLength(5))) {
Review Comment:
nit: == instead of equals, just to follow the pattern
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary merged pull request #3268: HIVE-26200: Add tests for Iceberg DELETE statements for every supported type
Posted by GitBox <gi...@apache.org>.
pvary merged PR #3268:
URL: https://github.com/apache/hive/pull/3268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org