[jira] [Commented] (HBASE-7867) setPreallocSize is different with COMMENT in setupTestEnv in MiniZooKeeperCluster.java

["DaeMyung Kang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580141#comment-13580141 ] 

DaeMyung Kang commented on HBASE-7867:
--------------------------------------

[~lhofhansl]ok, plz, fix the comment.

but if preAllocSize is 100, it might call this code "f.getChannel().write(fill, currentSize-fill.remaining());" in zookeeper/src/java/main/org/apache/zookeeper/server/persistence/Util.java every time.
                
> setPreallocSize is different with COMMENT in setupTestEnv in MiniZooKeeperCluster.java
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-7867
>                 URL: https://issues.apache.org/jira/browse/HBASE-7867
>             Project: HBase
>          Issue Type: Bug
>            Reporter: DaeMyung Kang
>            Priority: Trivial
>         Attachments: hbase-7867.patch
>
>
> setupTestEnv() just sets 100 bytes not 100k bytes
> {code}
> private static void setupTestEnv() {
> // / XXX: From o.a.zk.t.ClientBaseprivate static void setupTestEnv() {
> // during the tests we run with 100K prealloc in the logs.
> // on windows systems prealloc of 64M was seen to take ~15seconds
> // resulting in test failure (client timeout on first session).
> // set env and directly in order to handle static init/gc issues
>   System.setProperty("zookeeper.preAllocSize", "100");
>   FileTxnLog.setPreallocSize(100);
> }
> {code}
> to reduce too many call padLogFile(), I think 100k is correct.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira