You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/01/11 09:54:00 UTC
[GitHub] [beam] Jakub-Sadowski opened a new pull request #13718: [BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations
Jakub-Sadowski opened a new pull request #13718:
URL: https://github.com/apache/beam/pull/13718
Implemented:
- searchbar on top navigation
- left navigation
- right navigation
- join beam community page
- added hotjar
- fix hero component sizing on mobiles
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam
.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #13718: [BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #13718:
URL: https://github.com/apache/beam/pull/13718#discussion_r568269571
##########
File path: website/.gitignore
##########
@@ -1,23 +0,0 @@
-_site
-.doctrees
-.sass-cache
-.jekyll-metadata
-vendor/
-.bundle/
-content/
-
-# Ignore IntelliJ files.
-.idea/
-*.iml
-*.ipr
-*.iws
-
-# Hugo
-www/node_modules
-www/dist
-www/site/resources
-www/site/code_samples
-www/site/_config_branch_repo.toml
-www/yarn-error.log
-!www/site/content
-
Review comment:
This is a change that happened on master that's being duplicated here, please merge the website-revamp branch into this PR.
##########
File path: website/www/site/content/en/community/join-beam.md
##########
@@ -23,22 +23,24 @@ limitations under the License.
# Join Beam Community!
-We're glad that you decided to join us!
+We’re so glad you want to join the Apache Beam community. Here’s a pathway you can follow to help you get started. This is not the only way to join, but it’s the recommended progression so you’re successful at reaching your objectives.
-</br>
-
-### Stalk us
+## Join the Conversation
{{< community/join_beam_columns 0 >}}
-### Do your compulsory reading
+## Contribute to the Project
{{< community/join_beam_columns 1 >}}
-### Committer
+## Become a committer
+
+{{< community/join_beam_columns 2 >}}
+
+## Become a PMC member
{{< community/join_beam_columns 2 >}}
Review comment:
I think this should be something different, maybe `join_beam_columns 3`? Right now it's duplicating the committer information.
It would be nice if the key were a string with meaning rather than an integer
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which has the latest events organized by the community. }
- list:
- - Policies?
- - Documentation?
-
+ - { title: Read our Contribution Guide and Policies, description: Get familiar with our <a href="https://beam.apache.org/contribute/">contribution guide</a> and <a href="https://beam.apache.org/contribute/precommit-policies/">policies</a>. }
+ - { title: Create a Jira account, description: Create a <a href="https://issues.apache.org/jira/secure/Signup!default.jspa" target="_blank">Jira account</a> and send an email to dev@beam.apache.org to request comitter permissions. }
+ - { title: Find an area to contribute, description: Beam recognizes code and non-code contributions. Check out this Jira board for some inspiration. }
+ - { title: Contribute, description: To contribute code, you need to sign an Individual Contributor License Agreement (ICLA). Learn more here. }
+ - { title: Stay engaged !, description: Finds ways to stay engaged in the project and community and help us shape it’s strategy and vision. }
+- list:
+ - { title: Learn about Apache Beam Committers, description: Read how to become a committer to learn about ways to get nominated for committership. }
- list:
- - Check out the ways you can become a commiter
- - Here is a document that you should read
+ - { title: Learn about the Project Management Committee (PMC), description: The Project Management Committee (PMC) is the highest recognition in Apache projects. If you’re interested in becoming part of it, learn more about it here. }
Review comment:
"read *how to become a committer*" and "learn more about it *here*" in the PMC section have links to those documents.
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which has the latest events organized by the community. }
- list:
- - Policies?
- - Documentation?
-
+ - { title: Read our Contribution Guide and Policies, description: Get familiar with our <a href="https://beam.apache.org/contribute/">contribution guide</a> and <a href="https://beam.apache.org/contribute/precommit-policies/">policies</a>. }
+ - { title: Create a Jira account, description: Create a <a href="https://issues.apache.org/jira/secure/Signup!default.jspa" target="_blank">Jira account</a> and send an email to dev@beam.apache.org to request comitter permissions. }
+ - { title: Find an area to contribute, description: Beam recognizes code and non-code contributions. Check out this Jira board for some inspiration. }
+ - { title: Contribute, description: To contribute code, you need to sign an Individual Contributor License Agreement (ICLA). Learn more here. }
Review comment:
This is missing everything after "To contribute code", maybe it needs to be wrapped in quotes?
There also should be a link to some page about ICLAs in "Learn more *here*"
##########
File path: website/www/site/content/en/community/join-beam.md
##########
@@ -23,22 +23,24 @@ limitations under the License.
# Join Beam Community!
-We're glad that you decided to join us!
+We’re so glad you want to join the Apache Beam community. Here’s a pathway you can follow to help you get started. This is not the only way to join, but it’s the recommended progression so you’re successful at reaching your objectives.
-</br>
-
-### Stalk us
+## Join the Conversation
{{< community/join_beam_columns 0 >}}
-### Do your compulsory reading
+## Contribute to the Project
{{< community/join_beam_columns 1 >}}
-### Committer
+## Become a committer
+
+{{< community/join_beam_columns 2 >}}
+
+## Become a PMC member
{{< community/join_beam_columns 2 >}}
-### Still confused?
+## Still have questions?
-We're here for you! Check out ways you can talk to us and we will make sure to help.
+Send us a note to user@beam.apache.org OR mention@ApacheBeam on Twitter OR ask us in the #beam slack channel. We look forward to seeing you in the community!
Review comment:
I think it would be better to link to the contact us page, or even just not have this section at all. This page already mentions all of these channels.
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which has the latest events organized by the community. }
- list:
- - Policies?
- - Documentation?
-
+ - { title: Read our Contribution Guide and Policies, description: Get familiar with our <a href="https://beam.apache.org/contribute/">contribution guide</a> and <a href="https://beam.apache.org/contribute/precommit-policies/">policies</a>. }
+ - { title: Create a Jira account, description: Create a <a href="https://issues.apache.org/jira/secure/Signup!default.jspa" target="_blank">Jira account</a> and send an email to dev@beam.apache.org to request comitter permissions. }
+ - { title: Find an area to contribute, description: Beam recognizes code and non-code contributions. Check out this Jira board for some inspiration. }
Review comment:
Please add a link in "this jira board"
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which has the latest events organized by the community. }
Review comment:
Please add links for
- [ ] the-asf Slack
- [ ] @ApacheBeam Twitter
- [ ] Apache Beam YouTube
- [ ] StackOverflow apache-beam tag
- [ ] Event calendar.
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which has the latest events organized by the community. }
- list:
- - Policies?
- - Documentation?
-
+ - { title: Read our Contribution Guide and Policies, description: Get familiar with our <a href="https://beam.apache.org/contribute/">contribution guide</a> and <a href="https://beam.apache.org/contribute/precommit-policies/">policies</a>. }
+ - { title: Create a Jira account, description: Create a <a href="https://issues.apache.org/jira/secure/Signup!default.jspa" target="_blank">Jira account</a> and send an email to dev@beam.apache.org to request comitter permissions. }
+ - { title: Find an area to contribute, description: Beam recognizes code and non-code contributions. Check out this Jira board for some inspiration. }
+ - { title: Contribute, description: To contribute code, you need to sign an Individual Contributor License Agreement (ICLA). Learn more here. }
+ - { title: Stay engaged !, description: Finds ways to stay engaged in the project and community and help us shape it’s strategy and vision. }
Review comment:
nit: please remove the extra whitespace after "Stay engaged"
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which has the latest events organized by the community. }
- list:
- - Policies?
- - Documentation?
-
+ - { title: Read our Contribution Guide and Policies, description: Get familiar with our <a href="https://beam.apache.org/contribute/">contribution guide</a> and <a href="https://beam.apache.org/contribute/precommit-policies/">policies</a>. }
+ - { title: Create a Jira account, description: Create a <a href="https://issues.apache.org/jira/secure/Signup!default.jspa" target="_blank">Jira account</a> and send an email to dev@beam.apache.org to request comitter permissions. }
+ - { title: Find an area to contribute, description: Beam recognizes code and non-code contributions. Check out this Jira board for some inspiration. }
+ - { title: Contribute, description: To contribute code, you need to sign an Individual Contributor License Agreement (ICLA). Learn more here. }
+ - { title: Stay engaged !, description: Finds ways to stay engaged in the project and community and help us shape it’s strategy and vision. }
+- list:
+ - { title: Learn about Apache Beam Committers, description: Read how to become a committer to learn about ways to get nominated for committership. }
- list:
- - Check out the ways you can become a commiter
- - Here is a document that you should read
+ - { title: Learn about the Project Management Committee (PMC), description: The Project Management Committee (PMC) is the highest recognition in Apache projects. If you’re interested in becoming part of it, learn more about it here. }
Review comment:
"read *how to become a committer*" and "learn more about it *here*" in the PMC section should have links to those documents.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #13718: [BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #13718:
URL: https://github.com/apache/beam/pull/13718#discussion_r569596942
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -0,0 +1,29 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+- list:
+ - { title: Mailing Lists, description: 'Join the official Apache Beam user and developer mailing lists. Learn how <a href="/community/contact-us/">here</a>' }
+ - { title: Slack Channel, description: 'For real-time communication, join us on the <a target="_blank" href="https://app.slack.com/client/T4S1WH2J3/C9H0YNP3P">#beam</a> channel in the ASF workspace.' }
+ - { title: Twitter account, description: Follow '<a target="_blank" href="https://twitter.com/apachebeam?lang=en">@ApacheBeam</a> on Twitter for the most recent news on the project and community!' }
Review comment:
Fix my typo. This broke the PreCommit. Sorry!
```suggestion
- { title: Twitter account, description: 'Follow <a target="_blank" href="https://twitter.com/apachebeam?lang=en">@ApacheBeam</a> on Twitter for the most recent news on the project and community!' }
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #13718: [BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #13718:
URL: https://github.com/apache/beam/pull/13718#discussion_r568798777
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which has the latest events organized by the community. }
- list:
- - Policies?
- - Documentation?
-
+ - { title: Read our Contribution Guide and Policies, description: Get familiar with our <a href="https://beam.apache.org/contribute/">contribution guide</a> and <a href="https://beam.apache.org/contribute/precommit-policies/">policies</a>. }
+ - { title: Create a Jira account, description: Create a <a href="https://issues.apache.org/jira/secure/Signup!default.jspa" target="_blank">Jira account</a> and send an email to dev@beam.apache.org to request comitter permissions. }
+ - { title: Find an area to contribute, description: Beam recognizes code and non-code contributions. Check out this Jira board for some inspiration. }
+ - { title: Contribute, description: To contribute code, you need to sign an Individual Contributor License Agreement (ICLA). Learn more here. }
+ - { title: Stay engaged !, description: Finds ways to stay engaged in the project and community and help us shape it’s strategy and vision. }
+- list:
+ - { title: Learn about Apache Beam Committers, description: Read how to become a committer to learn about ways to get nominated for committership. }
- list:
- - Check out the ways you can become a commiter
- - Here is a document that you should read
+ - { title: Learn about the Project Management Committee (PMC), description: The Project Management Committee (PMC) is the highest recognition in Apache projects. If you’re interested in becoming part of it, learn more about it here. }
Review comment:
"read *how to become a committer*" and "learn more about it *here*" in the PMC section should have links to those documents.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #13718: [BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #13718:
URL: https://github.com/apache/beam/pull/13718#issuecomment-758095953
It looks like you've removed the .gitignore and checked in all the files in the `code_samples` directory. Can you remove those?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Jakub-Sadowski commented on a change in pull request #13718: [BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations
Posted by GitBox <gi...@apache.org>.
Jakub-Sadowski commented on a change in pull request #13718:
URL: https://github.com/apache/beam/pull/13718#discussion_r569308588
##########
File path: website/www/site/content/en/community/join-beam.md
##########
@@ -23,22 +23,24 @@ limitations under the License.
# Join Beam Community!
-We're glad that you decided to join us!
+We’re so glad you want to join the Apache Beam community. Here’s a pathway you can follow to help you get started. This is not the only way to join, but it’s the recommended progression so you’re successful at reaching your objectives.
-</br>
-
-### Stalk us
+## Join the Conversation
{{< community/join_beam_columns 0 >}}
-### Do your compulsory reading
+## Contribute to the Project
{{< community/join_beam_columns 1 >}}
-### Committer
+## Become a committer
+
+{{< community/join_beam_columns 2 >}}
+
+## Become a PMC member
{{< community/join_beam_columns 2 >}}
Review comment:
Ohh yeah there should be 3, I fixed this and also change it to variable `number-of-data`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Jakub-Sadowski commented on a change in pull request #13718: [BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations
Posted by GitBox <gi...@apache.org>.
Jakub-Sadowski commented on a change in pull request #13718:
URL: https://github.com/apache/beam/pull/13718#discussion_r569315636
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which has the latest events organized by the community. }
- list:
- - Policies?
- - Documentation?
-
+ - { title: Read our Contribution Guide and Policies, description: Get familiar with our <a href="https://beam.apache.org/contribute/">contribution guide</a> and <a href="https://beam.apache.org/contribute/precommit-policies/">policies</a>. }
+ - { title: Create a Jira account, description: Create a <a href="https://issues.apache.org/jira/secure/Signup!default.jspa" target="_blank">Jira account</a> and send an email to dev@beam.apache.org to request comitter permissions. }
+ - { title: Find an area to contribute, description: Beam recognizes code and non-code contributions. Check out this Jira board for some inspiration. }
+ - { title: Contribute, description: To contribute code, you need to sign an Individual Contributor License Agreement (ICLA). Learn more here. }
+ - { title: Stay engaged !, description: Finds ways to stay engaged in the project and community and help us shape it’s strategy and vision. }
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Jakub-Sadowski commented on pull request #13718: [BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations
Posted by GitBox <gi...@apache.org>.
Jakub-Sadowski commented on pull request #13718:
URL: https://github.com/apache/beam/pull/13718#issuecomment-758113849
> It looks like you've removed the .gitignore and checked in all the files in the `code_samples` directory. Can you remove those?
ohh yea I will fix this, sorry
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Jakub-Sadowski commented on a change in pull request #13718: [BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations
Posted by GitBox <gi...@apache.org>.
Jakub-Sadowski commented on a change in pull request #13718:
URL: https://github.com/apache/beam/pull/13718#discussion_r569338395
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which has the latest events organized by the community. }
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Jakub-Sadowski commented on a change in pull request #13718: [BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations
Posted by GitBox <gi...@apache.org>.
Jakub-Sadowski commented on a change in pull request #13718:
URL: https://github.com/apache/beam/pull/13718#discussion_r569315967
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which has the latest events organized by the community. }
- list:
- - Policies?
- - Documentation?
-
+ - { title: Read our Contribution Guide and Policies, description: Get familiar with our <a href="https://beam.apache.org/contribute/">contribution guide</a> and <a href="https://beam.apache.org/contribute/precommit-policies/">policies</a>. }
+ - { title: Create a Jira account, description: Create a <a href="https://issues.apache.org/jira/secure/Signup!default.jspa" target="_blank">Jira account</a> and send an email to dev@beam.apache.org to request comitter permissions. }
+ - { title: Find an area to contribute, description: Beam recognizes code and non-code contributions. Check out this Jira board for some inspiration. }
+ - { title: Contribute, description: To contribute code, you need to sign an Individual Contributor License Agreement (ICLA). Learn more here. }
Review comment:
Yes ur right, fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #13718: [BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #13718:
URL: https://github.com/apache/beam/pull/13718#issuecomment-772666635
Run Website_Stage_GCS PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Jakub-Sadowski commented on pull request #13718: [BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations
Posted by GitBox <gi...@apache.org>.
Jakub-Sadowski commented on pull request #13718:
URL: https://github.com/apache/beam/pull/13718#issuecomment-757859145
Review: @TheNeuralBit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #13718: [BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #13718:
URL: https://github.com/apache/beam/pull/13718#discussion_r569572119
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -0,0 +1,29 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+- list:
+ - { title: Mailing Lists, description: 'Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a>' }
+ - { title: Slack Channel, description: 'For real-time communication, join us on the <a target="_blank" href="https://app.slack.com/client/T4S1WH2J3/browse-channels">#beam channels</a> in the ASF workspace.' }
Review comment:
nit: let's make this link directly to the #beam channel (previously went to a browse page)
```suggestion
- { title: Slack Channel, description: 'For real-time communication, join us on the <a target="_blank" href="https://app.slack.com/client/T4S1WH2J3/C9H0YNP3P">#beam</a> channel in the ASF workspace.' }
```
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -0,0 +1,29 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+- list:
+ - { title: Mailing Lists, description: 'Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a>' }
+ - { title: Slack Channel, description: 'For real-time communication, join us on the <a target="_blank" href="https://app.slack.com/client/T4S1WH2J3/browse-channels">#beam channels</a> in the ASF workspace.' }
+ - { title: Twitter account, description: '<a target="_blank" href="https://twitter.com/apachebeam?lang=en">Follow @ApacheBeam</a> on Twitter for the most recent news on the project and community!' }
Review comment:
nit: only @ApacheBeam should be linked
```suggestion
- { title: Twitter account, description: Follow '<a target="_blank" href="https://twitter.com/apachebeam?lang=en">@ApacheBeam</a> on Twitter for the most recent news on the project and community!' }
```
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -0,0 +1,29 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+- list:
+ - { title: Mailing Lists, description: 'Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a>' }
Review comment:
nit: relative links
```suggestion
- { title: Mailing Lists, description: 'Join the official Apache Beam user and developer mailing lists. Learn how <a href="/community/contact-us/">here</a>' }
```
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -0,0 +1,29 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+- list:
+ - { title: Mailing Lists, description: 'Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a>' }
+ - { title: Slack Channel, description: 'For real-time communication, join us on the <a target="_blank" href="https://app.slack.com/client/T4S1WH2J3/browse-channels">#beam channels</a> in the ASF workspace.' }
+ - { title: Twitter account, description: '<a target="_blank" href="https://twitter.com/apachebeam?lang=en">Follow @ApacheBeam</a> on Twitter for the most recent news on the project and community!' }
+ - { title: YouTube channel, description: 'Follow our <a target="_blank" href="https://www.youtube.com/channel/UChNnb_YO_7B0HlW6FhAXZZQ">YouTube channel</a> for the latest training and use cases.' }
+ - { title: StackOverflow, description: 'Ask your Beam questions in StackOverflow using the <a target="_blank" href="https://stackoverflow.com/questions/tagged/apache-beam">apache-beam tag</a>.' }
+ - { title: Events, description: 'Follow our <a href="https://beam.apache.org/">calendar</a> in the homepage which has the latest events organized by the community.' }
+- list:
+ - { title: Read our Contribution Guide and Policies, description: 'Get familiar with our <a href="https://beam.apache.org/contribute/">contribution guide</a> and <a href="https://beam.apache.org/contribute/precommit-policies/">policies</a>.' }
+ - { title: Create a Jira account, description: 'Create a <a target="_blank" href="https://issues.apache.org/jira/secure/Signup!default.jspa" target="_blank">Jira account</a> and send an email to <a href="mailto:dev@beam.apache.org">dev@beam.apache.org</a> to request comitter permissions.' }
+ - { title: Find an area to contribute, description: 'Beam recognizes code and non-code contributions. Check out this <a target="_blank" href="https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12335926">Jira board</a> for some inspiration.' }
+ - { title: Contribute, description: 'To contribute code, you need to sign an <a href="https://www.apache.org/licenses/icla.pdf">Individual Contributor License Agreement (ICLA)</a>. Learn more <a target="_blank" href="https://www.apache.org/licenses/icla.pdf">here</a>.' }
+ - { title: Stay engaged!, description: Finds ways to stay engaged in the project and community and help us shape it’s strategy and vision. }
+- list:
+ - { title: Learn about Apache Beam Committers, description: 'Read <a href="https://beam.apache.org/contribute/become-a-committer/">how to become a committer</a> to learn about ways to get nominated for committership.' }
Review comment:
nit: relative links
```suggestion
- { title: Events, description: 'Follow our <a href="/">calendar</a> in the homepage which has the latest events organized by the community.' }
- list:
- { title: Read our Contribution Guide and Policies, description: 'Get familiar with our <a href="/contribute/">contribution guide</a> and <a href="/contribute/precommit-policies/">policies</a>.' }
- { title: Create a Jira account, description: 'Create a <a target="_blank" href="https://issues.apache.org/jira/secure/Signup!default.jspa" target="_blank">Jira account</a> and send an email to <a href="mailto:dev@beam.apache.org">dev@beam.apache.org</a> to request comitter permissions.' }
- { title: Find an area to contribute, description: 'Beam recognizes code and non-code contributions. Check out this <a target="_blank" href="https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12335926">Jira board</a> for some inspiration.' }
- { title: Contribute, description: 'To contribute code, you need to sign an <a href="https://www.apache.org/licenses/icla.pdf">Individual Contributor License Agreement (ICLA)</a>. Learn more <a target="_blank" href="https://www.apache.org/licenses/icla.pdf">here</a>.' }
- { title: Stay engaged!, description: Finds ways to stay engaged in the project and community and help us shape it’s strategy and vision. }
- list:
- { title: Learn about Apache Beam Committers, description: 'Read <a href="/contribute/become-a-committer/">how to become a committer</a> to learn about ways to get nominated for committership.' }
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #13718: [BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #13718:
URL: https://github.com/apache/beam/pull/13718#discussion_r568798085
##########
File path: website/www/site/content/en/community/join-beam.md
##########
@@ -23,22 +23,24 @@ limitations under the License.
# Join Beam Community!
-We're glad that you decided to join us!
+We’re so glad you want to join the Apache Beam community. Here’s a pathway you can follow to help you get started. This is not the only way to join, but it’s the recommended progression so you’re successful at reaching your objectives.
-</br>
-
-### Stalk us
+## Join the Conversation
{{< community/join_beam_columns 0 >}}
-### Do your compulsory reading
+## Contribute to the Project
{{< community/join_beam_columns 1 >}}
-### Committer
+## Become a committer
+
+{{< community/join_beam_columns 2 >}}
+
+## Become a PMC member
{{< community/join_beam_columns 2 >}}
Review comment:
I think this should be something different, maybe `join_beam_columns 3`? Right now it's duplicating the committer information.
It would be nice if the key were a string with meaning rather than an integer
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which has the latest events organized by the community. }
- list:
- - Policies?
- - Documentation?
-
+ - { title: Read our Contribution Guide and Policies, description: Get familiar with our <a href="https://beam.apache.org/contribute/">contribution guide</a> and <a href="https://beam.apache.org/contribute/precommit-policies/">policies</a>. }
+ - { title: Create a Jira account, description: Create a <a href="https://issues.apache.org/jira/secure/Signup!default.jspa" target="_blank">Jira account</a> and send an email to dev@beam.apache.org to request comitter permissions. }
+ - { title: Find an area to contribute, description: Beam recognizes code and non-code contributions. Check out this Jira board for some inspiration. }
+ - { title: Contribute, description: To contribute code, you need to sign an Individual Contributor License Agreement (ICLA). Learn more here. }
+ - { title: Stay engaged !, description: Finds ways to stay engaged in the project and community and help us shape it’s strategy and vision. }
+- list:
+ - { title: Learn about Apache Beam Committers, description: Read how to become a committer to learn about ways to get nominated for committership. }
- list:
- - Check out the ways you can become a commiter
- - Here is a document that you should read
+ - { title: Learn about the Project Management Committee (PMC), description: The Project Management Committee (PMC) is the highest recognition in Apache projects. If you’re interested in becoming part of it, learn more about it here. }
Review comment:
"read *how to become a committer*" and "learn more about it *here*" in the PMC section have links to those documents.
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which has the latest events organized by the community. }
- list:
- - Policies?
- - Documentation?
-
+ - { title: Read our Contribution Guide and Policies, description: Get familiar with our <a href="https://beam.apache.org/contribute/">contribution guide</a> and <a href="https://beam.apache.org/contribute/precommit-policies/">policies</a>. }
+ - { title: Create a Jira account, description: Create a <a href="https://issues.apache.org/jira/secure/Signup!default.jspa" target="_blank">Jira account</a> and send an email to dev@beam.apache.org to request comitter permissions. }
+ - { title: Find an area to contribute, description: Beam recognizes code and non-code contributions. Check out this Jira board for some inspiration. }
+ - { title: Contribute, description: To contribute code, you need to sign an Individual Contributor License Agreement (ICLA). Learn more here. }
Review comment:
This is missing everything after "To contribute code", maybe it needs to be wrapped in quotes?
There also should be a link to some page about ICLAs in "Learn more *here*"
##########
File path: website/www/site/content/en/community/join-beam.md
##########
@@ -23,22 +23,24 @@ limitations under the License.
# Join Beam Community!
-We're glad that you decided to join us!
+We’re so glad you want to join the Apache Beam community. Here’s a pathway you can follow to help you get started. This is not the only way to join, but it’s the recommended progression so you’re successful at reaching your objectives.
-</br>
-
-### Stalk us
+## Join the Conversation
{{< community/join_beam_columns 0 >}}
-### Do your compulsory reading
+## Contribute to the Project
{{< community/join_beam_columns 1 >}}
-### Committer
+## Become a committer
+
+{{< community/join_beam_columns 2 >}}
+
+## Become a PMC member
{{< community/join_beam_columns 2 >}}
-### Still confused?
+## Still have questions?
-We're here for you! Check out ways you can talk to us and we will make sure to help.
+Send us a note to user@beam.apache.org OR mention@ApacheBeam on Twitter OR ask us in the #beam slack channel. We look forward to seeing you in the community!
Review comment:
I think it would be better to link to the contact us page, or even just not have this section at all. This page already mentions all of these channels.
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which has the latest events organized by the community. }
- list:
- - Policies?
- - Documentation?
-
+ - { title: Read our Contribution Guide and Policies, description: Get familiar with our <a href="https://beam.apache.org/contribute/">contribution guide</a> and <a href="https://beam.apache.org/contribute/precommit-policies/">policies</a>. }
+ - { title: Create a Jira account, description: Create a <a href="https://issues.apache.org/jira/secure/Signup!default.jspa" target="_blank">Jira account</a> and send an email to dev@beam.apache.org to request comitter permissions. }
+ - { title: Find an area to contribute, description: Beam recognizes code and non-code contributions. Check out this Jira board for some inspiration. }
Review comment:
Please add a link in "this jira board"
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which has the latest events organized by the community. }
Review comment:
Please add links for
- [ ] the-asf Slack
- [ ] @ApacheBeam Twitter
- [ ] Apache Beam YouTube
- [ ] StackOverflow apache-beam tag
- [ ] Event calendar.
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which has the latest events organized by the community. }
- list:
- - Policies?
- - Documentation?
-
+ - { title: Read our Contribution Guide and Policies, description: Get familiar with our <a href="https://beam.apache.org/contribute/">contribution guide</a> and <a href="https://beam.apache.org/contribute/precommit-policies/">policies</a>. }
+ - { title: Create a Jira account, description: Create a <a href="https://issues.apache.org/jira/secure/Signup!default.jspa" target="_blank">Jira account</a> and send an email to dev@beam.apache.org to request comitter permissions. }
+ - { title: Find an area to contribute, description: Beam recognizes code and non-code contributions. Check out this Jira board for some inspiration. }
+ - { title: Contribute, description: To contribute code, you need to sign an Individual Contributor License Agreement (ICLA). Learn more here. }
+ - { title: Stay engaged !, description: Finds ways to stay engaged in the project and community and help us shape it’s strategy and vision. }
Review comment:
nit: please remove the extra whitespace after "Stay engaged"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #13718: [BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #13718:
URL: https://github.com/apache/beam/pull/13718#discussion_r568802545
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which has the latest events organized by the community. }
Review comment:
Please add links for
- [x] the-asf Slack
- [ ] @ApacheBeam Twitter
- [ ] Apache Beam YouTube
- [ ] StackOverflow apache-beam tag
- [ ] Event calendar.
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which has the latest events organized by the community. }
Review comment:
Please add links for
- [x] the-asf Slack
- [ ] @ApacheBeam Twitter
- [x] Apache Beam YouTube
- [ ] StackOverflow apache-beam tag
- [ ] Event calendar.
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which has the latest events organized by the community. }
Review comment:
Please add links for
- [x] the-asf Slack
- [x] @ApacheBeam Twitter
- [x] Apache Beam YouTube
- [ ] StackOverflow apache-beam tag
- [ ] Event calendar.
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which has the latest events organized by the community. }
Review comment:
Please add links for
- [x] the-asf Slack
- [x] @ApacheBeam Twitter
- [x] Apache Beam YouTube
- [x] StackOverflow apache-beam tag
- [ ] Event calendar.
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which has the latest events organized by the community. }
Review comment:
Please add links for
- [x] the-asf Slack
- [x] @ApacheBeam Twitter
- [x] Apache Beam YouTube
- [x] StackOverflow apache-beam tag
- [x] Event calendar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #13718: [BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged pull request #13718:
URL: https://github.com/apache/beam/pull/13718
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #13718: [BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #13718:
URL: https://github.com/apache/beam/pull/13718#discussion_r568269571
##########
File path: website/.gitignore
##########
@@ -1,23 +0,0 @@
-_site
-.doctrees
-.sass-cache
-.jekyll-metadata
-vendor/
-.bundle/
-content/
-
-# Ignore IntelliJ files.
-.idea/
-*.iml
-*.ipr
-*.iws
-
-# Hugo
-www/node_modules
-www/dist
-www/site/resources
-www/site/code_samples
-www/site/_config_branch_repo.toml
-www/yarn-error.log
-!www/site/content
-
Review comment:
This is a change that happened on master that's being duplicated here, please merge the website-revamp branch into this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Jakub-Sadowski commented on a change in pull request #13718: [BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations
Posted by GitBox <gi...@apache.org>.
Jakub-Sadowski commented on a change in pull request #13718:
URL: https://github.com/apache/beam/pull/13718#discussion_r569340286
##########
File path: website/www/site/content/en/community/join-beam.md
##########
@@ -23,22 +23,24 @@ limitations under the License.
# Join Beam Community!
-We're glad that you decided to join us!
+We’re so glad you want to join the Apache Beam community. Here’s a pathway you can follow to help you get started. This is not the only way to join, but it’s the recommended progression so you’re successful at reaching your objectives.
-</br>
-
-### Stalk us
+## Join the Conversation
{{< community/join_beam_columns 0 >}}
-### Do your compulsory reading
+## Contribute to the Project
{{< community/join_beam_columns 1 >}}
-### Committer
+## Become a committer
+
+{{< community/join_beam_columns 2 >}}
+
+## Become a PMC member
{{< community/join_beam_columns 2 >}}
-### Still confused?
+## Still have questions?
-We're here for you! Check out ways you can talk to us and we will make sure to help.
+Send us a note to user@beam.apache.org OR mention@ApacheBeam on Twitter OR ask us in the #beam slack channel. We look forward to seeing you in the community!
Review comment:
all things are linked now
##########
File path: website/www/site/data/en/join_beam.yaml
##########
@@ -11,15 +11,20 @@
# limitations under the License.
- list:
- - Join Slack
- - Follow us on Twitter to get the latest information
- - Follow us on YouTube to know first about the latest tutorials
- - Follow meetup closest to your city
+ - { title: Mailing Lists, description: Join the official Apache Beam user and developer mailing lists. Learn how <a href="https://beam.apache.org/community/contact-us/">here</a> }
+ - { title: Slack Channel, description: "For real-time communication, join us on the #beam channels in the ASF workspace." }
+ - { title: Twitter account, description: Follow @ApacheBeam on Twitter for the most recent news on the project and community! }
+ - { title: YouTube channel, description: Follow our YouTube channel for the latest training and use cases. }
+ - { title: StackOverflow, description: Ask your Beam questions in StackOverflow using the apache-beam tag. }
+ - { title: Events, description: Follow our calendar in the homepage which has the latest events organized by the community. }
- list:
- - Policies?
- - Documentation?
-
+ - { title: Read our Contribution Guide and Policies, description: Get familiar with our <a href="https://beam.apache.org/contribute/">contribution guide</a> and <a href="https://beam.apache.org/contribute/precommit-policies/">policies</a>. }
+ - { title: Create a Jira account, description: Create a <a href="https://issues.apache.org/jira/secure/Signup!default.jspa" target="_blank">Jira account</a> and send an email to dev@beam.apache.org to request comitter permissions. }
+ - { title: Find an area to contribute, description: Beam recognizes code and non-code contributions. Check out this Jira board for some inspiration. }
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #13718: [BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #13718:
URL: https://github.com/apache/beam/pull/13718#discussion_r569509776
##########
File path: website/www/site/content/en/community/join-beam.md
##########
@@ -0,0 +1,46 @@
+---
+title: "Join Beam Community"
+aliases:
+ - /community/
+ - /use/issue-tracking/
+ - /use/mailing-lists/
+ - /get-started/support/
+---
+
+<!--
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->
+
+# Join Beam Community!
+
+We’re so glad you want to join the Apache Beam community. Here’s a pathway you can follow to help you get started. This is not the only way to join, but it’s the recommended progression so you’re successful at reaching your objectives.
+
+## Join the Conversation
+
+{{< community/join_beam_columns number-of-data="0" >}}
+
+## Contribute to the Project
+
+{{< community/join_beam_columns number-of-data="1" >}}
+
+## Become a committer
+
+{{< community/join_beam_columns number-of-data="2" >}}
+
+## Become a PMC member
+
+{{< community/join_beam_columns number-of-data="3" >}}
+
+## Still have questions?
+
+Send us a note to user@beam.apache.org OR mention@ApacheBeam on Twitter OR ask us in the #beam slack channel. We look forward to seeing you in the community!
Review comment:
It looks like this was the copy from the TDD, but I think we should make some minor adjustments (I updated the TDD as well), and add some links:
```suggestion
Send us a note at <a href="mailto:dev@beam.apache.org">user@beam.apache.org</a> OR mention <a target="_blank" href="https://twitter.com/apachebeam?lang=en">@ApacheBeam</a> on Twitter OR ask us in the #beam slack channel. We look forward to seeing you in the community!
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org