You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by lu...@apache.org on 2019/07/09 10:17:45 UTC

[incubator-weex] branch master updated: [Android] Fix potential NPE (#2662)

This is an automated email from the ASF dual-hosted git repository.

luckychen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-weex.git


The following commit(s) were added to refs/heads/master by this push:
     new 159ccdc  [Android] Fix potential NPE (#2662)
159ccdc is described below

commit 159ccdc2f80baea89c559d547b857dacf2203000
Author: YorkShen <sh...@gmail.com>
AuthorDate: Tue Jul 9 18:17:41 2019 +0800

    [Android] Fix potential NPE (#2662)
---
 .../main/java/com/taobao/weex/ui/view/WXHorizontalScrollView.java   | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/view/WXHorizontalScrollView.java b/android/sdk/src/main/java/com/taobao/weex/ui/view/WXHorizontalScrollView.java
index 7c17d33..9f4cdde 100644
--- a/android/sdk/src/main/java/com/taobao/weex/ui/view/WXHorizontalScrollView.java
+++ b/android/sdk/src/main/java/com/taobao/weex/ui/view/WXHorizontalScrollView.java
@@ -24,12 +24,10 @@ import android.util.AttributeSet;
 import android.view.MotionEvent;
 import android.view.View;
 import android.widget.HorizontalScrollView;
-
 import com.taobao.weex.ui.view.gesture.WXGesture;
 import com.taobao.weex.ui.view.gesture.WXGestureObservable;
-
-import java.util.ArrayList;
 import java.util.List;
+import java.util.concurrent.CopyOnWriteArrayList;
 
 public class WXHorizontalScrollView extends HorizontalScrollView implements IWXScroller, WXGestureObservable {
 
@@ -77,7 +75,7 @@ public class WXHorizontalScrollView extends HorizontalScrollView implements IWXS
 
   public void addScrollViewListener(ScrollViewListener scrollViewListener) {
     if (mScrollViewListeners == null) {
-      mScrollViewListeners = new ArrayList<>();
+      mScrollViewListeners = new CopyOnWriteArrayList<>();
     }
     if (!mScrollViewListeners.contains(scrollViewListener)) {
       mScrollViewListeners.add(scrollViewListener);