You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ws.apache.org by ve...@apache.org on 2012/09/05 10:37:48 UTC
svn commit: r1381066 - in /webservices/commons/trunk/modules/axiom/modules:
axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/
axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/
axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/
Author: veithen
Date: Wed Sep 5 08:37:48 2012
New Revision: 1381066
URL: http://svn.apache.org/viewvc?rev=1381066&view=rev
Log:
Added another test case that reveals a problem in DOOM.
Added:
webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestSetAttributeNSExisting.java (with props)
Modified:
webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/DOMTestSuiteBuilder.java
webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/DOMImplementationTest.java
Modified: webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/DOMTestSuiteBuilder.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/DOMTestSuiteBuilder.java?rev=1381066&r1=1381065&r2=1381066&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/DOMTestSuiteBuilder.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/DOMTestSuiteBuilder.java Wed Sep 5 08:37:48 2012
@@ -142,6 +142,7 @@ public class DOMTestSuiteBuilder extends
for (int i=0; i<validAttrQNames.length; i++) {
addTest(new org.apache.axiom.ts.dom.element.TestSetAttributeNS(dbf, validAttrQNames[i], "value"));
}
+ addTest(new org.apache.axiom.ts.dom.element.TestSetAttributeNSExisting(dbf));
for (int i=0; i<invalidAttrQNames.length; i++) {
addTest(new org.apache.axiom.ts.dom.element.TestSetAttributeNSInvalid(dbf, invalidAttrQNames[i]));
}
Added: webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestSetAttributeNSExisting.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestSetAttributeNSExisting.java?rev=1381066&view=auto
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestSetAttributeNSExisting.java (added)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestSetAttributeNSExisting.java Wed Sep 5 08:37:48 2012
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.axiom.ts.dom.element;
+
+import javax.xml.parsers.DocumentBuilderFactory;
+
+import org.apache.axiom.ts.dom.DOMTestCase;
+import org.w3c.dom.Attr;
+import org.w3c.dom.Document;
+import org.w3c.dom.Element;
+
+/**
+ * Tests the behavior of {@link Element#setAttributeNS(String, String, String)} if the element
+ * already has an attribute with the same namespace URI and local name.
+ */
+public class TestSetAttributeNSExisting extends DOMTestCase {
+ public TestSetAttributeNSExisting(DocumentBuilderFactory dbf) {
+ super(dbf);
+ }
+
+ protected void runTest() throws Throwable {
+ Document document = dbf.newDocumentBuilder().newDocument();
+ Element element = document.createElementNS(null, "test");
+
+ // Add the original attribute
+ Attr attr = document.createAttributeNS("urn:test", "p1:attr");
+ attr.setValue("value1");
+ element.setAttributeNodeNS(attr);
+
+ // Now change the attribute using setAttributeNS
+ element.setAttributeNS("urn:test", "p2:attr", "value2");
+
+ // DOM is expected to change the original attribute, not to create a new one
+ assertEquals("value2", attr.getValue());
+ assertEquals("p2", attr.getPrefix());
+ }
+}
Propchange: webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestSetAttributeNSExisting.java
------------------------------------------------------------------------------
svn:eol-style = native
Modified: webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/DOMImplementationTest.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/DOMImplementationTest.java?rev=1381066&r1=1381065&r2=1381066&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/DOMImplementationTest.java (original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/DOMImplementationTest.java Wed Sep 5 08:37:48 2012
@@ -25,6 +25,7 @@ import org.apache.axiom.om.impl.dom.fact
import org.apache.axiom.ts.dom.DOMTestSuiteBuilder;
import org.apache.axiom.ts.dom.document.TestCreateAttributeNS;
import org.apache.axiom.ts.dom.document.TestCreateAttributeNSInvalid;
+import org.apache.axiom.ts.dom.element.TestSetAttributeNSExisting;
import org.apache.axiom.ts.dom.element.TestSetAttributeNSInvalid;
public class DOMImplementationTest extends TestCase {
@@ -35,6 +36,7 @@ public class DOMImplementationTest exten
builder.exclude(TestCreateAttributeNS.class, "(name=xmlns)");
builder.exclude(TestCreateAttributeNSInvalid.class);
builder.exclude(TestSetAttributeNSInvalid.class);
+ builder.exclude(TestSetAttributeNSExisting.class);
return builder.build();
}