You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/07/02 17:59:37 UTC
[kudu-CR] KUDU-2671 mark --enable per range hash schemas as 'advanced'
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18694
Change subject: KUDU-2671 mark --enable_per_range_hash_schemas as 'advanced'
......................................................................
KUDU-2671 mark --enable_per_range_hash_schemas as 'advanced'
Since the functionality for KUDU-2671 is almost there, this patch
removes the 'unsafe' tag from the newly introduced
--enable_per_range_hash_schemas flag which enables support for
range-specific hash schemas. Now the flag is marked as 'advanced'
instead and also marked as 'runtime' as well.
Change-Id: Iecfebf908745d279bb7a276806c7c96b363ba8db
---
M src/kudu/master/catalog_manager.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/18694/1
--
To view, visit http://gerrit.cloudera.org:8080/18694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecfebf908745d279bb7a276806c7c96b363ba8db
Gerrit-Change-Number: 18694
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] KUDU-2671 mark --enable per range hash schemas as 'advanced'
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18694 )
Change subject: KUDU-2671 mark --enable_per_range_hash_schemas as 'advanced'
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecfebf908745d279bb7a276806c7c96b363ba8db
Gerrit-Change-Number: 18694
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 Jul 2022 18:04:40 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 mark --enable per range hash schemas as 'advanced'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18694 )
Change subject: KUDU-2671 mark --enable_per_range_hash_schemas as 'advanced'
......................................................................
Patch Set 1: Verified+1
unrelated test failure in log-rolling-itest
--
To view, visit http://gerrit.cloudera.org:8080/18694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecfebf908745d279bb7a276806c7c96b363ba8db
Gerrit-Change-Number: 18694
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 Jul 2022 20:35:11 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 mark --enable per range hash schemas as 'advanced'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18694 )
Change subject: KUDU-2671 mark --enable_per_range_hash_schemas as 'advanced'
......................................................................
KUDU-2671 mark --enable_per_range_hash_schemas as 'advanced'
Since the functionality for KUDU-2671 is almost there, this patch
removes the 'unsafe' tag from the newly introduced
--enable_per_range_hash_schemas flag which enables support for
range-specific hash schemas. Now the flag is marked as 'advanced'
instead and also marked as 'runtime' as well.
Change-Id: Iecfebf908745d279bb7a276806c7c96b363ba8db
Reviewed-on: http://gerrit.cloudera.org:8080/18694
Reviewed-by: Attila Bukor <ab...@apache.org>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/master/catalog_manager.cc
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Attila Bukor: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iecfebf908745d279bb7a276806c7c96b363ba8db
Gerrit-Change-Number: 18694
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 mark --enable per range hash schemas as 'advanced'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-2671 mark --enable_per_range_hash_schemas as 'advanced'
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Iecfebf908745d279bb7a276806c7c96b363ba8db
Gerrit-Change-Number: 18694
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>