You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/07 08:45:03 UTC
[GitHub] [apisix-ingress-controller] Fatpa opened a new issue, #1072: request help: should we use githook for pre-commit operation
Fatpa opened a new issue, #1072:
URL: https://github.com/apache/apisix-ingress-controller/issues/1072
### Issue description
During the contribute document, we have some pre-commit to-do tasks to do manually.
I think we should use the githook function to avoid manual jobs.
### Environment
Nothing about the environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] request help: should we use githook for pre-commit operation [apisix-ingress-controller]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop closed issue #1072: request help: should we use githook for pre-commit operation
URL: https://github.com/apache/apisix-ingress-controller/issues/1072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1072: request help: should we use githook for pre-commit operation
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #1072:
URL: https://github.com/apache/apisix-ingress-controller/issues/1072#issuecomment-1148781661
I have thought about this way, it can bring certain benefits.
But most open source projects don't choose it.
On the other hand, these operations are not required for every commit.
I tend to keep these things in the hands of CI, giving more freedom to contributors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org