[GitHub] [incubator-doris] blackfox1983 commented on a change in pull request #3513: [Doris On ES]fix bug of query failed in doc_value_mode when fields have none value

[GitBox <gi...@apache.org>]

blackfox1983 commented on a change in pull request #3513:
URL: https://github.com/apache/incubator-doris/pull/3513#discussion_r421917673



##########
File path: be/src/exec/es/es_scroll_parser.cpp
##########
@@ -275,7 +286,32 @@ int ScrollParser::get_total() {
 Status ScrollParser::fill_tuple(const TupleDescriptor* tuple_desc, 
             Tuple* tuple, MemPool* tuple_pool, bool* line_eof, const std::map<std::string, std::string>& docvalue_context) {
     *line_eof = true;
+
     if (_size <= 0 || _line_index >= _size) {

Review comment:
       i don't think so.
   This problem is mainly triggered when _size = 0 and _total > 0。if use `_total`，parser() will return OK() and `_size` remain 0, the problem would not exist.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org