You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org> on 2006/06/09 00:21:29 UTC
[jira] Created: (ADFFACES-20) Skinning: Comment inside a selector
in skin css generates invalid style.
Skinning: Comment inside a selector in skin css generates invalid style.
------------------------------------------------------------------------
Key: ADFFACES-20
URL: http://issues.apache.org/jira/browse/ADFFACES-20
Project: MyFaces ADF-Faces
Type: Bug
Reporter: Jeanne Waldman
If you have a comment in the skinning .css file like this:
* html .DemoStatusPriority {
/* some comment */
background-image: url('images/warning.gif');
}
The generated CSS file contained the following output:
.DemoStatusNotPriority,background-image: url('images/warning.xak
}
Removing the comment makes the problem go away.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-20) Skinning: Comment inside a selector
in skin css generates invalid style.
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-20?page=comments#action_12415614 ]
Jeanne Waldman commented on ADFFACES-20:
----------------------------------------
The fix is to parse the properties string and replace all comments with the empty string. I use a Pattern to do this, which is compiled in a static block.
> Skinning: Comment inside a selector in skin css generates invalid style.
> ------------------------------------------------------------------------
>
> Key: ADFFACES-20
> URL: http://issues.apache.org/jira/browse/ADFFACES-20
> Project: MyFaces ADF-Faces
> Type: Bug
> Reporter: Jeanne Waldman
> Assignee: Matthias Weßendorf
> Attachments: skin_commentissuefix
>
> If you have a comment in the skinning .css file like this:
> * html .DemoStatusPriority {
> /* some comment */
> background-image: url('images/warning.gif');
> }
> The generated CSS file contained the following output:
> .DemoStatusNotPriority,background-image: url('images/warning.xak
> }
> Removing the comment makes the problem go away.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-20) Skinning: Comment inside a selector
in skin css generates invalid style.
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-20?page=comments#action_12415452 ]
Jeanne Waldman commented on ADFFACES-20:
----------------------------------------
I have a fix that I need to upload.
> Skinning: Comment inside a selector in skin css generates invalid style.
> ------------------------------------------------------------------------
>
> Key: ADFFACES-20
> URL: http://issues.apache.org/jira/browse/ADFFACES-20
> Project: MyFaces ADF-Faces
> Type: Bug
> Reporter: Jeanne Waldman
>
> If you have a comment in the skinning .css file like this:
> * html .DemoStatusPriority {
> /* some comment */
> background-image: url('images/warning.gif');
> }
> The generated CSS file contained the following output:
> .DemoStatusNotPriority,background-image: url('images/warning.xak
> }
> Removing the comment makes the problem go away.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-20) Skinning: Comment inside a selector
in skin css generates invalid style.
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-20?page=all ]
Jeanne Waldman updated ADFFACES-20:
-----------------------------------
Attachment: skin_commentissuefix
This fixes the skin issue ADFFACES-19 as well
> Skinning: Comment inside a selector in skin css generates invalid style.
> ------------------------------------------------------------------------
>
> Key: ADFFACES-20
> URL: http://issues.apache.org/jira/browse/ADFFACES-20
> Project: MyFaces ADF-Faces
> Type: Bug
> Reporter: Jeanne Waldman
> Assignee: Matthias Weßendorf
> Attachments: skin_commentissuefix
>
> If you have a comment in the skinning .css file like this:
> * html .DemoStatusPriority {
> /* some comment */
> background-image: url('images/warning.gif');
> }
> The generated CSS file contained the following output:
> .DemoStatusNotPriority,background-image: url('images/warning.xak
> }
> Removing the comment makes the problem go away.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-20) Skinning: Comment inside a selector
in skin css generates invalid style.
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated ADFFACES-20:
---------------------------------------
Fix Version/s: 1.0.0-incubating-core
Affects Version/s: 1.0.0-incubating-core
> Skinning: Comment inside a selector in skin css generates invalid style.
> ------------------------------------------------------------------------
>
> Key: ADFFACES-20
> URL: https://issues.apache.org/jira/browse/ADFFACES-20
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Affects Versions: 1.0.0-incubating-core
> Reporter: Jeanne Waldman
> Assigned To: Matthias Weßendorf
> Fix For: 1.0.0-incubating-core
>
> Attachments: skin_commentissuefix
>
>
> If you have a comment in the skinning .css file like this:
> * html .DemoStatusPriority {
> /* some comment */
> background-image: url('images/warning.gif');
> }
> The generated CSS file contained the following output:
> .DemoStatusNotPriority,background-image: url('images/warning.xak
> }
> Removing the comment makes the problem go away.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ADFFACES-20) Skinning: Comment inside a selector
in skin css generates invalid style.
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-20?page=all ]
Matthias Weßendorf reassigned ADFFACES-20:
------------------------------------------
Assign To: Matthias Weßendorf
> Skinning: Comment inside a selector in skin css generates invalid style.
> ------------------------------------------------------------------------
>
> Key: ADFFACES-20
> URL: http://issues.apache.org/jira/browse/ADFFACES-20
> Project: MyFaces ADF-Faces
> Type: Bug
> Reporter: Jeanne Waldman
> Assignee: Matthias Weßendorf
>
> If you have a comment in the skinning .css file like this:
> * html .DemoStatusPriority {
> /* some comment */
> background-image: url('images/warning.gif');
> }
> The generated CSS file contained the following output:
> .DemoStatusNotPriority,background-image: url('images/warning.xak
> }
> Removing the comment makes the problem go away.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (ADFFACES-20) Skinning: Comment inside a selector in
skin css generates invalid style.
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-20?page=all ]
Matthias Weßendorf closed ADFFACES-20:
--------------------------------------
Resolution: Fixed
applied patch from Jeanne Waldman.
> Skinning: Comment inside a selector in skin css generates invalid style.
> ------------------------------------------------------------------------
>
> Key: ADFFACES-20
> URL: http://issues.apache.org/jira/browse/ADFFACES-20
> Project: MyFaces ADF-Faces
> Type: Bug
> Reporter: Jeanne Waldman
> Assignee: Matthias Weßendorf
> Attachments: skin_commentissuefix
>
> If you have a comment in the skinning .css file like this:
> * html .DemoStatusPriority {
> /* some comment */
> background-image: url('images/warning.gif');
> }
> The generated CSS file contained the following output:
> .DemoStatusNotPriority,background-image: url('images/warning.xak
> }
> Removing the comment makes the problem go away.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-20) Skinning: Comment inside a selector
in skin css generates invalid style.
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-20?page=comments#action_12415456 ]
Matthias Weßendorf commented on ADFFACES-20:
--------------------------------------------
Hey Jeanne,
When you have fixed an issue, please create a patch file and load it up to the Jira issue tracking system. One of the committers will take care of that patch.
Thanks,
Matthias
> Skinning: Comment inside a selector in skin css generates invalid style.
> ------------------------------------------------------------------------
>
> Key: ADFFACES-20
> URL: http://issues.apache.org/jira/browse/ADFFACES-20
> Project: MyFaces ADF-Faces
> Type: Bug
> Reporter: Jeanne Waldman
>
> If you have a comment in the skinning .css file like this:
> * html .DemoStatusPriority {
> /* some comment */
> background-image: url('images/warning.gif');
> }
> The generated CSS file contained the following output:
> .DemoStatusNotPriority,background-image: url('images/warning.xak
> }
> Removing the comment makes the problem go away.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-20) Skinning: Comment inside a selector
in skin css generates invalid style.
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-20?page=all ]
Jeanne Waldman updated ADFFACES-20:
-----------------------------------
Status: Patch Available (was: Open)
> Skinning: Comment inside a selector in skin css generates invalid style.
> ------------------------------------------------------------------------
>
> Key: ADFFACES-20
> URL: http://issues.apache.org/jira/browse/ADFFACES-20
> Project: MyFaces ADF-Faces
> Type: Bug
> Reporter: Jeanne Waldman
> Assignee: Matthias Weßendorf
>
> If you have a comment in the skinning .css file like this:
> * html .DemoStatusPriority {
> /* some comment */
> background-image: url('images/warning.gif');
> }
> The generated CSS file contained the following output:
> .DemoStatusNotPriority,background-image: url('images/warning.xak
> }
> Removing the comment makes the problem go away.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira