You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/08 10:02:23 UTC

[GitHub] [spark] yikf commented on a change in pull request #31520: [SPARK-34355][SQL][FOLLOWUP] Log FileBatchWrite's commit time too

yikf commented on a change in pull request #31520:
URL: https://github.com/apache/spark/pull/31520#discussion_r571915730



##########
File path: core/src/main/scala/org/apache/spark/internal/io/SparkHadoopWriterUtils.scala
##########
@@ -106,6 +110,18 @@ object SparkHadoopWriterUtils {
     }
   }
 
+  def commitJob(
+      job: JobContext,
+      uuid: String,
+      committer: FileCommitProtocol,
+      commitMsgs: Seq[TaskCommitMessage]): Long = {

Review comment:
       The retrun value of `commitJob` seems not be used.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org