You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/11/12 21:57:04 UTC

Review Request 40253: Added URI protobuf definition.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40253/
-----------------------------------------------------------

Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.


Repository: mesos


Description
-------

Added URI protobuf definition.


Diffs
-----

  src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698 
  src/uri/uri.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/40253/diff/


Testing
-------

make check


Thanks,

Jie Yu

Re: Review Request 40253: Added URI protobuf definition.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40253/#review106761
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Nov. 16, 2015, 8:09 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40253/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 8:09 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added URI protobuf definition.
> 
> 
> Diffs
> -----
> 
>   include/mesos/uri/uri.hpp PRE-CREATION 
>   include/mesos/uri/uri.proto PRE-CREATION 
>   src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
> 
> Diff: https://reviews.apache.org/r/40253/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 40253: Added URI protobuf definition.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40253/
-----------------------------------------------------------

(Updated Nov. 18, 2015, 11:26 p.m.)


Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.


Bugs: MESOS-3921
    https://issues.apache.org/jira/browse/MESOS-3921


Repository: mesos


Description
-------

Added URI protobuf definition.


Diffs
-----

  include/mesos/uri/uri.hpp PRE-CREATION 
  include/mesos/uri/uri.proto PRE-CREATION 
  src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 
  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 

Diff: https://reviews.apache.org/r/40253/diff/


Testing
-------

make check


Thanks,

Jie Yu

Re: Review Request 40253: Added URI protobuf definition.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40253/
-----------------------------------------------------------

(Updated Nov. 17, 2015, 8:43 p.m.)


Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.


Changes
-------

Made 'path' required.


Repository: mesos


Description
-------

Added URI protobuf definition.


Diffs (updated)
-----

  include/mesos/uri/uri.hpp PRE-CREATION 
  include/mesos/uri/uri.proto PRE-CREATION 
  src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 
  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 

Diff: https://reviews.apache.org/r/40253/diff/


Testing
-------

make check


Thanks,

Jie Yu

Re: Review Request 40253: Added URI protobuf definition.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40253/
-----------------------------------------------------------

(Updated Nov. 16, 2015, 8:09 p.m.)


Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.


Changes
-------

Review comments.


Repository: mesos


Description
-------

Added URI protobuf definition.


Diffs (updated)
-----

  include/mesos/uri/uri.hpp PRE-CREATION 
  include/mesos/uri/uri.proto PRE-CREATION 
  src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 
  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 

Diff: https://reviews.apache.org/r/40253/diff/


Testing
-------

make check


Thanks,

Jie Yu

Re: Review Request 40253: Added URI protobuf definition.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40253/
-----------------------------------------------------------

(Updated Nov. 16, 2015, 7:06 p.m.)


Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.


Changes
-------

Moved to public headers.


Repository: mesos


Description
-------

Added URI protobuf definition.


Diffs (updated)
-----

  include/mesos/uri/uri.hpp PRE-CREATION 
  include/mesos/uri/uri.proto PRE-CREATION 
  src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 
  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 

Diff: https://reviews.apache.org/r/40253/diff/


Testing
-------

make check


Thanks,

Jie Yu

Re: Review Request 40253: Added URI protobuf definition.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40253/#review106525
-----------------------------------------------------------

Ship it!



src/uri/uri.proto (line 23)
<https://reviews.apache.org/r/40253/#comment165229>

    Represents


- Vinod Kone


On Nov. 13, 2015, 2:15 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40253/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 2:15 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added URI protobuf definition.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9 
>   src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698 
>   src/uri/uri.hpp PRE-CREATION 
>   src/uri/uri.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40253/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 40253: Added URI protobuf definition.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40253/#review106700
-----------------------------------------------------------


I just realized that I need to access this in a 3rdparty fetcher module. So I'll expose it in the public header.

- Jie Yu


On Nov. 13, 2015, 2:15 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40253/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 2:15 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added URI protobuf definition.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9 
>   src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698 
>   src/uri/uri.hpp PRE-CREATION 
>   src/uri/uri.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40253/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 40253: Added URI protobuf definition.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40253/#review106361
-----------------------------------------------------------


Patch looks great!

Reviews applied: [40250, 40251, 40252, 40274, 40253]

All tests passed.

- Mesos ReviewBot


On Nov. 13, 2015, 2:15 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40253/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 2:15 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added URI protobuf definition.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9 
>   src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698 
>   src/uri/uri.hpp PRE-CREATION 
>   src/uri/uri.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40253/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 40253: Added URI protobuf definition.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40253/
-----------------------------------------------------------

(Updated Nov. 13, 2015, 2:15 a.m.)


Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.


Changes
-------

Added missing proto file in src/Makefile.am


Repository: mesos


Description
-------

Added URI protobuf definition.


Diffs (updated)
-----

  src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9 
  src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698 
  src/uri/uri.hpp PRE-CREATION 
  src/uri/uri.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/40253/diff/


Testing
-------

make check


Thanks,

Jie Yu