[jira] [Commented] (GIRAPH-595) InternalVertexRunner.run() should take GiraphConfiguration, not GiraphClasses

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GIRAPH-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630809#comment-13630809 ] 

Hudson commented on GIRAPH-595:
-------------------------------

Integrated in Giraph-trunk-Commit #915 (See [https://builds.apache.org/job/Giraph-trunk-Commit/915/])
    GIRAPH-595: InternalVertexRunner.run() should take GiraphConfiguration, not GiraphClasses (nitay via apresta) (Revision db077ec209ddc22946fb6060609d5a6529682356)

     Result = SUCCESS
alessandro : http://git-wip-us.apache.org/repos/asf?p=giraph.git&a=commit&h=db077ec209ddc22946fb6060609d5a6529682356
Files : 
* giraph-examples/src/test/java/org/apache/giraph/examples/PageRankVertexTest.java
* giraph-core/src/main/java/org/apache/giraph/io/formats/GiraphFileInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java
* giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java
* giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTest.java
* giraph-examples/src/test/java/org/apache/giraph/TestPartitionContext.java
* giraph-examples/src/test/java/org/apache/giraph/TestManualCheckpoint.java
* giraph-examples/src/test/java/org/apache/giraph/examples/SimpleShortestPathsVertexTest.java
* giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java
* giraph-examples/src/test/java/org/apache/giraph/TestMutateGraph.java
* giraph-core/src/main/java/org/apache/giraph/utils/TestGraph.java
* giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTestInMemory.java
* giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java
* giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
* giraph-examples/src/test/java/org/apache/giraph/aggregators/TestAggregatorsHandling.java
* giraph-examples/src/test/java/org/apache/giraph/TestGraphPartitioner.java
* giraph-core/src/test/java/org/apache/giraph/master/TestMasterObserver.java
* giraph-core/src/test/java/org/apache/giraph/BspCase.java
* giraph-core/src/main/java/org/apache/giraph/benchmark/WeightedPageRankBenchmark.java
* giraph-examples/src/test/java/org/apache/giraph/TestAutoCheckpoint.java
* giraph-core/src/main/java/org/apache/giraph/benchmark/ShortestPathsBenchmark.java
* giraph-examples/src/test/java/org/apache/giraph/examples/TryMultiIpcBindingPortsTest.java
* giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java
* giraph-examples/src/main/java/org/apache/giraph/examples/SimpleShortestPathsVertex.java
* giraph-examples/src/test/java/org/apache/giraph/TestNotEnoughMapTasks.java
* giraph-core/src/test/java/org/apache/giraph/io/TestEdgeInput.java
* CHANGELOG
* giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
* giraph-examples/src/test/java/org/apache/giraph/examples/RandomWalkWithRestartVertexTest.java
* giraph-examples/src/test/java/org/apache/giraph/TestMaxSuperstep.java
* giraph-core/src/test/java/org/apache/giraph/io/TestJsonBase64Format.java
* giraph-examples/src/test/java/org/apache/giraph/examples/TestPageRank.java

                
> InternalVertexRunner.run() should take GiraphConfiguration, not GiraphClasses
> -----------------------------------------------------------------------------
>
>                 Key: GIRAPH-595
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-595
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Alessandro Presta
>            Assignee: Nitay Joffe
>         Attachments: GIRAPH-595.patch, GIRAPH-595.patch
>
>
> The current way GiraphClasses is used is not ideal for two reasons:
> 1) InternalVertexRunner has to add all those wrapper calls like conf.setXXXClass(classes.getXXXClass()). This is verbose and fragile since it has to be updated every time we add a new type of class.
> 2) The configuration flow is circular: the user creates a GiraphClasses, which is used to create GiraphConfiguration, which is used to create ImmutableClassesGiraphConfiguration, which creates a new GiraphClasses!
> https://reviews.apache.org/r/10387/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira