You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/03/04 08:43:56 UTC
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6641: Adding a check for multi-value column in star tree indexing config
fx19880617 commented on a change in pull request #6641:
URL: https://github.com/apache/incubator-pinot/pull/6641#discussion_r587269212
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
##########
@@ -371,6 +371,7 @@ private static void validateIndexingConfig(@Nullable IndexingConfig indexingConf
}
Map<String, String> columnNameToConfigMap = new HashMap<>();
Set<String> noDictionaryColumnsSet = new HashSet<>();
+ String STAR_TREE_CONFIG_NAME = "StarTreeIndex Config";
Review comment:
make this static?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org