You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by "marcelstoer (via GitHub)" <gi...@apache.org> on 2023/08/23 08:45:15 UTC
[GitHub] [shiro] marcelstoer opened a new pull request, #1042: Fix the Maven Central badge
marcelstoer opened a new pull request, #1042:
URL: https://github.com/apache/shiro/pull/1042
The badge should actually link to Central.
<!--
For Security Vulnerabilities, please email: security@shiro.apache.org
For more details on how to report a vulnerablity see: https://www.apache.org/security/
-->
Following this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [GitHub issue](https://github.com/apache/shiro/issues) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[#XXX] - Fixes bug in SessionManager`,
where you replace `#XXX` with the appropriate GitHub issue. Best practice
is to use the GitHub issue title in the pull request title and in the first line of the commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] add `fixes #XXX` if merging the PR should close a related issue.
- [ ] Run `mvn verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
- [ ] Committers: Make sure a milestone is set on the PR
Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like `[DOC] - Add javadoc in SessionManager`.
If this is your first contribution, you have to read the [Contribution Guidelines](https://github.com/apache/shiro/blob/master/CONTRIBUTING.md)
If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf)
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] lprimak merged pull request #1042: Fix the Maven Central badge
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak merged PR #1042:
URL: https://github.com/apache/shiro/pull/1042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] marcelstoer commented on pull request #1042: Fix the Maven Central badge
Posted by "marcelstoer (via GitHub)" <gi...@apache.org>.
marcelstoer commented on PR #1042:
URL: https://github.com/apache/shiro/pull/1042#issuecomment-1690073954
Using https://github.com/softwaremill/maven-badges instead of shields.io for the Maven badge would give us a little more convenience but I deemed my current fix good enough for most.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bdemers commented on pull request #1042: Fix the Maven Central badge
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers commented on PR #1042:
URL: https://github.com/apache/shiro/pull/1042#issuecomment-1690067473
Awesome! thanks @marcelstoer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] marcelstoer commented on pull request #1042: Fix the Maven Central badge
Posted by "marcelstoer (via GitHub)" <gi...@apache.org>.
marcelstoer commented on PR #1042:
URL: https://github.com/apache/shiro/pull/1042#issuecomment-1690141855
I have no preference, we might also link to https://central.sonatype.com/artifact/org.apache.shiro/shiro-core/ instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] lprimak commented on pull request #1042: Fix the Maven Central badge
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #1042:
URL: https://github.com/apache/shiro/pull/1042#issuecomment-1690157912
Well, it's a redirect now, so I feel like sonatype.org would better. I talked to some folks at sonatype and they say "big changs" are coming, so I would say the new stuff is gonna stick around :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org