You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2018/10/09 21:36:53 UTC
[kudu-CR](branch-1.8.x) Fix RAT warnings
Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11631
to review the following change.
Change subject: Fix RAT warnings
......................................................................
Fix RAT warnings
Change-Id: If18dc7321ba0294d9d640064f25e5b3d3bca1914
---
M build-support/release/rat_exclude_files.txt
M examples/java/collectl/src/main/java/org/apache/kudu/examples/KuduCollectlExample.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KuduSinkTestUtil.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
5 files changed, 78 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/11631/1
--
To view, visit http://gerrit.cloudera.org:8080/11631
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: If18dc7321ba0294d9d640064f25e5b3d3bca1914
Gerrit-Change-Number: 11631
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR](branch-1.8.x) Fix RAT warnings
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has abandoned this change. ( http://gerrit.cloudera.org:8080/11631 )
Change subject: Fix RAT warnings
......................................................................
Abandoned
pushing to master instead
--
To view, visit http://gerrit.cloudera.org:8080/11631
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: abandon
Gerrit-Change-Id: If18dc7321ba0294d9d640064f25e5b3d3bca1914
Gerrit-Change-Number: 11631
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-1.8.x) Fix RAT warnings
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11631 )
Change subject: Fix RAT warnings
......................................................................
Patch Set 1:
(1 comment)
> Patch Set 1:
>
> These should probably go to master and then be cherry-picked back to the 1.8 branch.
yeah good idea, I'll submit it to master instead
http://gerrit.cloudera.org:8080/#/c/11631/1/build-support/release/rat_exclude_files.txt
File build-support/release/rat_exclude_files.txt:
http://gerrit.cloudera.org:8080/#/c/11631/1/build-support/release/rat_exclude_files.txt@34
PS1, Line 34: java/kudu-flume-sink/src/test/avro/testAvroKuduOperationsProducer.avsc
> I don't think this line is needed.
Done
--
To view, visit http://gerrit.cloudera.org:8080/11631
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If18dc7321ba0294d9d640064f25e5b3d3bca1914
Gerrit-Change-Number: 11631
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 09 Oct 2018 21:47:19 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Fix RAT warnings
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11631 )
Change subject: Fix RAT warnings
......................................................................
Fix RAT warnings
Change-Id: If18dc7321ba0294d9d640064f25e5b3d3bca1914
Reviewed-on: http://gerrit.cloudera.org:8080/11632
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
(cherry picked from commit 88edfc36a888d53445b0e24159a10bf7de8b5213)
Reviewed-on: http://gerrit.cloudera.org:8080/11631
---
M build-support/release/rat_exclude_files.txt
M examples/java/collectl/src/main/java/org/apache/kudu/examples/KuduCollectlExample.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KuduSinkTestUtil.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
5 files changed, 73 insertions(+), 1 deletion(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11631
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: merged
Gerrit-Change-Id: If18dc7321ba0294d9d640064f25e5b3d3bca1914
Gerrit-Change-Number: 11631
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-1.8.x) Fix RAT warnings
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has restored this change. ( http://gerrit.cloudera.org:8080/11631 )
Change subject: Fix RAT warnings
......................................................................
Restored
--
To view, visit http://gerrit.cloudera.org:8080/11631
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: restore
Gerrit-Change-Id: If18dc7321ba0294d9d640064f25e5b3d3bca1914
Gerrit-Change-Number: 11631
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-1.8.x) Fix RAT warnings
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11631 )
Change subject: Fix RAT warnings
......................................................................
Patch Set 1:
These should probably go to master and then be cherry-picked back to the 1.8 branch.
--
To view, visit http://gerrit.cloudera.org:8080/11631
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If18dc7321ba0294d9d640064f25e5b3d3bca1914
Gerrit-Change-Number: 11631
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 09 Oct 2018 21:39:33 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.8.x) Fix RAT warnings
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11631 )
Change subject: Fix RAT warnings
......................................................................
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11631
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If18dc7321ba0294d9d640064f25e5b3d3bca1914
Gerrit-Change-Number: 11631
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 10 Oct 2018 01:52:53 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.8.x) Fix RAT warnings
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11631 )
Change subject: Fix RAT warnings
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11631/1/build-support/release/rat_exclude_files.txt
File build-support/release/rat_exclude_files.txt:
http://gerrit.cloudera.org:8080/#/c/11631/1/build-support/release/rat_exclude_files.txt@34
PS1, Line 34: java/kudu-flume-sink/src/test/avro/testAvroKuduOperationsProducer.avsc
I don't think this line is needed.
--
To view, visit http://gerrit.cloudera.org:8080/11631
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If18dc7321ba0294d9d640064f25e5b3d3bca1914
Gerrit-Change-Number: 11631
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 09 Oct 2018 21:38:50 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Fix RAT warnings
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: Fix RAT warnings
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11631
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If18dc7321ba0294d9d640064f25e5b3d3bca1914
Gerrit-Change-Number: 11631
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-1.8.x) Fix RAT warnings
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11631
to look at the new patch set (#3).
Change subject: Fix RAT warnings
......................................................................
Fix RAT warnings
Change-Id: If18dc7321ba0294d9d640064f25e5b3d3bca1914
Reviewed-on: http://gerrit.cloudera.org:8080/11632
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
(cherry picked from commit 88edfc36a888d53445b0e24159a10bf7de8b5213)
---
M build-support/release/rat_exclude_files.txt
M examples/java/collectl/src/main/java/org/apache/kudu/examples/KuduCollectlExample.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KuduSinkTestUtil.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
5 files changed, 73 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/11631/3
--
To view, visit http://gerrit.cloudera.org:8080/11631
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If18dc7321ba0294d9d640064f25e5b3d3bca1914
Gerrit-Change-Number: 11631
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins