[lucene-solr] branch master updated: LUCENE-9090: remove ant runtime pollution from tests classpath

[rm...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

rmuir pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/master by this push:
     new f894bd0  LUCENE-9090: remove ant runtime pollution from tests classpath
f894bd0 is described below

commit f894bd019e254bc4a9aa2d509e27a6ba5b07bfe7
Author: Robert Muir <rm...@apache.org>
AuthorDate: Wed Dec 11 20:23:35 2019 -0500

    LUCENE-9090: remove ant runtime pollution from tests classpath
    
    previously, entire classpath of ant (ant itself, plugins, ivy, etc) were
    polluting the unit tests classpath. it leads to non-reproducible build
    issues because tests classpath is different depending on things outside
    of source code control.
    
    for example, solr tests launching hadoop, hadoop launching jetty, jetty
    scanning classpath -> boom
---
 lucene/common-build.xml         | 1 -
 lucene/core/build.xml           | 1 -
 lucene/module-build.xml         | 1 -
 lucene/test-framework/build.xml | 1 -
 4 files changed, 4 deletions(-)

diff --git a/lucene/common-build.xml b/lucene/common-build.xml
index c76dd54..e077c6b 100644
--- a/lucene/common-build.xml
+++ b/lucene/common-build.xml
@@ -2549,7 +2549,6 @@ The following arguments can be provided to ant to alter its behaviour and target
         <path id="pitest.classpath">
             <path refid="junit.classpath"/>
             <path refid="pitest.framework.classpath"/>
-            <pathelement path="${java.class.path}"/>
         </path>
 
         <junit4:pickseed property="pitest.seed" />
diff --git a/lucene/core/build.xml b/lucene/core/build.xml
index d968798..4a9ed05 100644
--- a/lucene/core/build.xml
+++ b/lucene/core/build.xml
@@ -41,7 +41,6 @@
 
   <path id="junit.classpath">
     <path refid="test.classpath"/>
-    <pathelement path="${java.class.path}"/>
   </path>
 
   <target name="test-core" depends="common.test"/>
diff --git a/lucene/module-build.xml b/lucene/module-build.xml
index e73f0fc..c0eab1a 100644
--- a/lucene/module-build.xml
+++ b/lucene/module-build.xml
@@ -47,7 +47,6 @@
   <path id="junit.classpath">
     <pathelement location="${build.dir}/classes/test"/>
     <path refid="test.classpath"/>
-    <pathelement path="${java.class.path}"/>
   </path>
 
   <target name="init" depends="common.init,compile-lucene-core"/>
diff --git a/lucene/test-framework/build.xml b/lucene/test-framework/build.xml
index d09a50f..844c557 100644
--- a/lucene/test-framework/build.xml
+++ b/lucene/test-framework/build.xml
@@ -39,7 +39,6 @@
 
   <path id="junit.classpath">
     <path refid="test.classpath"/>
-    <pathelement path="${java.class.path}"/>
   </path>
 
   <!--