You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "reswqa (via GitHub)" <gi...@apache.org> on 2025/03/06 08:17:55 UTC
[PR] [FLINK-32482][docker] Add Java 21 to build matrix [flink-docker]
reswqa opened a new pull request, #217:
URL: https://github.com/apache/flink-docker/pull/217
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-32482][docker] Add Java 21 to build matrix and set default image to Java 17 [flink-docker]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #217:
URL: https://github.com/apache/flink-docker/pull/217#discussion_r1982929521
##########
add-version.sh:
##########
@@ -59,7 +59,7 @@ fi
# Defaults, can vary between versions
scala_versions=( 2.12 )
-java_versions=( 8 11 17 )
+java_versions=( 11 17 21 )
Review Comment:
No, this PR is for `dev-master`(This branch is intended for a subsequent release), and I will pick this to dev-2.0 then.
We should direct change `dev-1.20` branch if we want do something for the old version(1.20).
##########
add-version.sh:
##########
@@ -59,7 +59,7 @@ fi
# Defaults, can vary between versions
scala_versions=( 2.12 )
-java_versions=( 8 11 17 )
+java_versions=( 11 17 21 )
Review Comment:
No, this PR is for `dev-master`(This branch is intended for a subsequent release), and I will pick this to dev-2.0 then(for 2.0.0 rc1).
We should direct change `dev-1.20` branch if we want do something for the old version(1.20).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-32482][docker] Add Java 21 to build matrix and set default image to Java 17 [flink-docker]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #217:
URL: https://github.com/apache/flink-docker/pull/217#discussion_r1982929521
##########
add-version.sh:
##########
@@ -59,7 +59,7 @@ fi
# Defaults, can vary between versions
scala_versions=( 2.12 )
-java_versions=( 8 11 17 )
+java_versions=( 11 17 21 )
Review Comment:
No, this PR is for `dev-master`(This branch is intended for a subsequent release), and I will pick this to dev-2.0 then(for 2.0.0 rc1).
We should directly change `dev-1.20` branch if we want do something for the old version(1.20).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-32482][docker] Add Java 21 to build matrix and set default image to Java 17 [flink-docker]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #217:
URL: https://github.com/apache/flink-docker/pull/217#discussion_r1982929521
##########
add-version.sh:
##########
@@ -59,7 +59,7 @@ fi
# Defaults, can vary between versions
scala_versions=( 2.12 )
-java_versions=( 8 11 17 )
+java_versions=( 11 17 21 )
Review Comment:
No, this PR is for `dev-master`(This branch is intended for a new major release), and I will pick this to dev-2.0 then(for 2.0.0 rc1).
We should directly change `dev-1.20` branch if we want do something for the old version(1.20).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-32482][docker] Add Java 21 to build matrix and set default image to Java 17 [flink-docker]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa merged PR #217:
URL: https://github.com/apache/flink-docker/pull/217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-32482][docker] Add Java 21 to build matrix and set default image to Java 17 [flink-docker]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #217:
URL: https://github.com/apache/flink-docker/pull/217#discussion_r1982922528
##########
add-version.sh:
##########
@@ -59,7 +59,7 @@ fi
# Defaults, can vary between versions
scala_versions=( 2.12 )
-java_versions=( 8 11 17 )
+java_versions=( 11 17 21 )
Review Comment:
is the same script use for 1.20.x?
if yes, then jdk8 still might be required for 1.20.2
Similar question bout default
##########
add-version.sh:
##########
@@ -59,7 +59,7 @@ fi
# Defaults, can vary between versions
scala_versions=( 2.12 )
-java_versions=( 8 11 17 )
+java_versions=( 11 17 21 )
Review Comment:
is the same script used for 1.20.x?
if yes, then jdk8 still might be required for 1.20.2
Similar question bout default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-32482][docker] Add Java 21 to build matrix and set default image to Java 17 [flink-docker]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #217:
URL: https://github.com/apache/flink-docker/pull/217#discussion_r1982929521
##########
add-version.sh:
##########
@@ -59,7 +59,7 @@ fi
# Defaults, can vary between versions
scala_versions=( 2.12 )
-java_versions=( 8 11 17 )
+java_versions=( 11 17 21 )
Review Comment:
No, this PR is for `dev-master`(This branch is intended for a subsequent release), and I will pick this on to dev-2.0 then.
We should direct change `dev-1.20` branch if we want do something for the old version(1.20).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-32482][docker] Add Java 21 to build matrix and set default image to Java 17 [flink-docker]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #217:
URL: https://github.com/apache/flink-docker/pull/217#discussion_r1982922528
##########
add-version.sh:
##########
@@ -59,7 +59,7 @@ fi
# Defaults, can vary between versions
scala_versions=( 2.12 )
-java_versions=( 8 11 17 )
+java_versions=( 11 17 21 )
Review Comment:
is the same script used for 1.20.x?
if yes, then jdk8 still might be required for 1.20.2
Similar question about default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-32482][docker] Add Java 21 to build matrix and set default image to Java 17 [flink-docker]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #217:
URL: https://github.com/apache/flink-docker/pull/217#issuecomment-2703186943
@snuyanzin The CI not pickup for jdk11 because we push nightly binary release to s3 with jdk17(Cannot run under jdk11 setup)... I think we should change it also to jdk11(https://github.com/apache/flink/pull/26260).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org