[GitHub] [cloudstack] anuragaw edited a comment on issue #3293: Limit selecting of secondary storage with 90% utilization

[GitBox <gi...@apache.org>]

anuragaw edited a comment on issue #3293: Limit selecting of secondary storage with 90% utilization
URL: https://github.com/apache/cloudstack/pull/3293#issuecomment-488622762
 
 
   I can suggest doing some more tests with storage to max capacity -
   1. Creating snapshots (VM and Storage)
   2. Launching VMs
   3. Migrating Volumes
   
   The only place I saw where the null check was not carried was in `SecondaryStorageManagerImpl`-
   ```    @Override
       public boolean finalizeVirtualMachineProfile(VirtualMachineProfile profile, DeployDestination dest, ReservationContext context) {
           SecondaryStorageVmVO vm = _secStorageVmDao.findById(profile.getId());
           Map<String, String> details = _vmDetailsDao.listDetailsKeyPairs(vm.getId());
           vm.setDetails(details);
   
           DataStore secStore = _dataStoreMgr.getImageStore(dest.getDataCenter().getId());
           assert (secStore != null);
   ```
   
   I hope it helps.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services