[PR] THRIFT-6303: Use FDictionary in the Delphi 2010 branch of ToArray [thrift]

["Jens-G (via GitHub)" <gi...@apache.org>]

Jens-G opened a new pull request, #3888:
URL: https://github.com/apache/thrift/pull/3888

   [THRIFT-6303](https://issues.apache.org/jira/browse/THRIFT-6303)
   
   `TThriftDictionaryImpl<TKey,TValue>.ToArray` has a separate branch for Delphi 2010 (`CompilerVersion < 22.0`). THRIFT-5686 (f5627536b, first released in 0.19.0) renamed the field `FDictionaly` to `FDictionary` but did not update this branch:
   
   ```pascal
   {$IF CompilerVersion < 22.0}
     SetLength(Result, Count);
     i := 0;
     for x in FDictionaly do
   ```
   
   `FDictionaly` is no longer declared anywhere. As a result, `Thrift.Collections` does not compile with Delphi 2010, the minimum version documented in `lib/delphi/README.md`. Delphi XE and later take the `{$ELSE}` branch and are not affected.
   
   ### Verification
   
   I had no Delphi 2010 to compile this with. Instead, I built the library experimentally with Free Pascal and `CompilerVersion` set to 21.0. Without the change the branch fails with `Identifier not found "FDictionaly"`; with it, the branch compiles. `FDictionary` is the field the other branch already uses.
   
   There is no new test. The defect only appears when the Delphi 2010 branch is compiled, and no CI job does that.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] THRIFT-6303: Use FDictionary in the Delphi 2010 branch of ToArray [thrift]

["Jens-G (via GitHub)" <gi...@apache.org>]

Jens-G merged PR #3888:
URL: https://github.com/apache/thrift/pull/3888


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org