You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Anton Lindström <an...@alley.se> on 2014/03/06 07:58:10 UTC

Review Request 18837: Remove flag J from tar command in fetcher

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18837/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-1051
    https://issues.apache.org/jira/browse/MESOS-1051


Repository: mesos-git


Description
-------

This removes the J flag from tar command in fetcher so that we'll hopefully be able to untar all formats with the -xf flags on all platforms.


Diffs
-----

  src/launcher/fetcher.cpp 263dd7080693d1455309e648b738cf44fb1d49f5 

Diff: https://reviews.apache.org/r/18837/diff/


Testing
-------

make check

tar -cvJf test.tar.xz test
tar -xf test.tar.xz

tar -cvzf test.tar.gz test
tar -xf test.tar.xz


Thanks,

Anton Lindström

Re: Review Request 18837: Remove flag J from tar command in fetcher

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18837/#review36346
-----------------------------------------------------------

Ship it!


Thanks!

- Vinod Kone


On March 6, 2014, 6:58 a.m., Anton Lindström wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18837/
> -----------------------------------------------------------
> 
> (Updated March 6, 2014, 6:58 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1051
>     https://issues.apache.org/jira/browse/MESOS-1051
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This removes the J flag from tar command in fetcher so that we'll hopefully be able to untar all formats with the -xf flags on all platforms.
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp 263dd7080693d1455309e648b738cf44fb1d49f5 
> 
> Diff: https://reviews.apache.org/r/18837/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> tar -cvJf test.tar.xz test
> tar -xf test.tar.xz
> 
> tar -cvzf test.tar.gz test
> tar -xf test.tar.xz
> 
> 
> Thanks,
> 
> Anton Lindström
> 
>