You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/01/31 23:41:41 UTC
Review Request 56144: Added unit test for http::Headers abstraction.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56144/
-----------------------------------------------------------
Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, Shuai Lin, and Timothy Chen.
Repository: mesos
Description
-------
Added unit test for http::Headers abstraction.
Diffs
-----
3rdparty/libprocess/src/tests/http_tests.cpp b12849e506f4340b865840072e583dfddecaf02a
Diff: https://reviews.apache.org/r/56144/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 56144: Added unit test for http::Headers
abstraction.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56144/#review163931
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56116, 56117, 54537, 56144]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 2, 2017, 12:59 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56144/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2017, 12:59 a.m.)
>
>
> Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, Shuai Lin, and Timothy Chen.
>
>
> Bugs: MESOS-7051
> https://issues.apache.org/jira/browse/MESOS-7051
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit test for http::Headers abstraction.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/http_tests.cpp b12849e506f4340b865840072e583dfddecaf02a
>
> Diff: https://reviews.apache.org/r/56144/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 56144: Added unit test for http::Headers
abstraction.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56144/#review163960
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56116, 56117, 54537, 56144]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 2, 2017, 8:40 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56144/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2017, 8:40 a.m.)
>
>
> Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, Shuai Lin, and Timothy Chen.
>
>
> Bugs: MESOS-7051
> https://issues.apache.org/jira/browse/MESOS-7051
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit test for http::Headers abstraction.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/http_tests.cpp b12849e506f4340b865840072e583dfddecaf02a
>
> Diff: https://reviews.apache.org/r/56144/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 56144: Added unit test for http::Headers
abstraction.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56144/
-----------------------------------------------------------
(Updated Feb. 2, 2017, 12:40 a.m.)
Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, Shuai Lin, and Timothy Chen.
Changes
-------
Added Headers::empty() test.
Bugs: MESOS-7051
https://issues.apache.org/jira/browse/MESOS-7051
Repository: mesos
Description
-------
Added unit test for http::Headers abstraction.
Diffs (updated)
-----
3rdparty/libprocess/src/tests/http_tests.cpp b12849e506f4340b865840072e583dfddecaf02a
Diff: https://reviews.apache.org/r/56144/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 56144: Added unit test for http::Headers
abstraction.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56144/
-----------------------------------------------------------
(Updated Feb. 1, 2017, 4:59 p.m.)
Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, Shuai Lin, and Timothy Chen.
Bugs: MESOS-7051
https://issues.apache.org/jira/browse/MESOS-7051
Repository: mesos
Description
-------
Added unit test for http::Headers abstraction.
Diffs
-----
3rdparty/libprocess/src/tests/http_tests.cpp b12849e506f4340b865840072e583dfddecaf02a
Diff: https://reviews.apache.org/r/56144/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 56144: Added unit test for http::Headers
abstraction.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56144/
-----------------------------------------------------------
(Updated Feb. 1, 2017, 4:44 p.m.)
Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, Shuai Lin, and Timothy Chen.
Repository: mesos
Description
-------
Added unit test for http::Headers abstraction.
Diffs (updated)
-----
3rdparty/libprocess/src/tests/http_tests.cpp b12849e506f4340b865840072e583dfddecaf02a
Diff: https://reviews.apache.org/r/56144/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 56144: Added unit test for http::Headers
abstraction.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56144/#review163765
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56116, 56117, 54537, 56144]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 31, 2017, 11:41 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56144/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 11:41 p.m.)
>
>
> Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, Shuai Lin, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit test for http::Headers abstraction.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/http_tests.cpp b12849e506f4340b865840072e583dfddecaf02a
>
> Diff: https://reviews.apache.org/r/56144/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>