[GitHub] [cassandra-builds] smiklosovic edited a comment on issue #18: added Docker image for Debian Buster

[GitBox <gi...@apache.org>]

smiklosovic edited a comment on issue #18: added Docker image for Debian Buster
URL: https://github.com/apache/cassandra-builds/pull/18#issuecomment-609814279
 
 
   @michaelsembwever one thing might be problematic here, there is this file (1).
   
   If this is built with Java 8, it has to be run with Java 8 and more. If it is built with Java 11, it has to be run with Java 11 and more.
   
   I do not see any _simple_ way how to reflect this into that `control` file. I would say that this should be changed to be dependable on Java 11 as by that way, we can run it with Java 8 too if one really wants that to be the case as he would configure it manually via alternatives afterwards (but he would have to have Cassandra built with Java 8, obviously).
   
   Should I take this path with trying to patch `debian/control` in Cassandra? 
   
   Other solution would be to make two `control` files and we would overwrite the main with the "control-11" in case we detect the build should be done with Java 11. I am not strong in Debian package creation so there might be other way but after merely looking I dont see any option.
   
   When it comes to this PR, args would be just propagated to build_debs.sh script and based on that, there would be set env property `CASSANDRA_USE_JDK11=true` so debs scripts would invoke ant jar with this (and ant would run implicitly with Java 11 too as we would make that switch in build_deps.sh script).
   
   (1) https://github.com/apache/cassandra/blob/trunk/debian/control#L14

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org