You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by David Grizzanti <da...@sungard.com> on 2013/02/26 15:18:15 UTC
Review Request: CLOUDSTACK-420: listZones missing name parameter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9590/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
CLOUDSTACK-420: listZones missing name parameter
When calling the listZones API command, you can now supply a name to pull a specific zone by name.
Updated two classes to include name paramater and query data centers/zones by name if suppled:
- server/src/com/cloud/api/query/QueryManagerImpl.java
- api/src/org/apache/cloudstack/api/command/user/zone/ListZonesByCmd.java
This addresses bug CLOUDSTACK-420.
Diffs
-----
api/src/org/apache/cloudstack/api/command/user/zone/ListZonesByCmd.java 97fe2ffeb909e8cd5f985b5bf9f5276c67354110
server/src/com/cloud/api/query/QueryManagerImpl.java 51312a60eb1c5b6b7a988d072731e3735765260c
Diff: https://reviews.apache.org/r/9590/diff/
Testing
-------
Verified on DevCloud running 4.1
Thanks,
David Grizzanti
Re: Review Request: CLOUDSTACK-420: listZones missing name parameter
Posted by Chip Childers <ch...@sungard.com>.
On Thu, Mar 14, 2013 at 11:52:36AM -0700, Animesh Chaturvedi wrote:
> David
>
> Please mark patch as submitted
I took care of that.
>
> > -----Original Message-----
> > From: Prasanna Santhanam [mailto:noreply@reviews.apache.org] On Behalf
> > Of Prasanna Santhanam
> > Sent: Wednesday, February 27, 2013 12:17 AM
> > To: cloudstack; Prasanna Santhanam; David Grizzanti
> > Subject: Re: Review Request: CLOUDSTACK-420: listZones missing name
> > parameter
> >
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/9590/#review17141
> > -----------------------------------------------------------
> >
> > Ship it!
> >
> >
> > Merged after testing with cloudmonkey+devcloud. Thanks for the patch. Do
> > consider using git format-patch for reviewboard so we can attribute author
> > information easily.
> >
> > 53b6ba379899985ee1a40ade1aca7a1e9777ff71 (master)
> > 2fc5a3ca5e1539ef42b92c59fb0e42e1c6c73bc5 (4.1)
> >
> > - Prasanna Santhanam
> >
> >
> > On Feb. 26, 2013, 2:18 p.m., David Grizzanti wrote:
> > >
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > https://reviews.apache.org/r/9590/
> > > -----------------------------------------------------------
> > >
> > > (Updated Feb. 26, 2013, 2:18 p.m.)
> > >
> > >
> > > Review request for cloudstack.
> > >
> > >
> > > Description
> > > -------
> > >
> > > CLOUDSTACK-420: listZones missing name parameter
> > >
> > > When calling the listZones API command, you can now supply a name to
> > pull a specific zone by name.
> > >
> > > Updated two classes to include name paramater and query data
> > centers/zones by name if suppled:
> > > - server/src/com/cloud/api/query/QueryManagerImpl.java
> > > -
> > api/src/org/apache/cloudstack/api/command/user/zone/ListZonesByCmd.ja
> > va
> > >
> > >
> > > This addresses bug CLOUDSTACK-420.
> > >
> > >
> > > Diffs
> > > -----
> > >
> > >
> > api/src/org/apache/cloudstack/api/command/user/zone/ListZonesByCmd.ja
> > va 97fe2ffeb909e8cd5f985b5bf9f5276c67354110
> > > server/src/com/cloud/api/query/QueryManagerImpl.java
> > 51312a60eb1c5b6b7a988d072731e3735765260c
> > >
> > > Diff: https://reviews.apache.org/r/9590/diff/
> > >
> > >
> > > Testing
> > > -------
> > >
> > > Verified on DevCloud running 4.1
> > >
> > >
> > > Thanks,
> > >
> > > David Grizzanti
> > >
> > >
>
RE: Review Request: CLOUDSTACK-420: listZones missing name parameter
Posted by Animesh Chaturvedi <an...@citrix.com>.
David
Please mark patch as submitted
> -----Original Message-----
> From: Prasanna Santhanam [mailto:noreply@reviews.apache.org] On Behalf
> Of Prasanna Santhanam
> Sent: Wednesday, February 27, 2013 12:17 AM
> To: cloudstack; Prasanna Santhanam; David Grizzanti
> Subject: Re: Review Request: CLOUDSTACK-420: listZones missing name
> parameter
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9590/#review17141
> -----------------------------------------------------------
>
> Ship it!
>
>
> Merged after testing with cloudmonkey+devcloud. Thanks for the patch. Do
> consider using git format-patch for reviewboard so we can attribute author
> information easily.
>
> 53b6ba379899985ee1a40ade1aca7a1e9777ff71 (master)
> 2fc5a3ca5e1539ef42b92c59fb0e42e1c6c73bc5 (4.1)
>
> - Prasanna Santhanam
>
>
> On Feb. 26, 2013, 2:18 p.m., David Grizzanti wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/9590/
> > -----------------------------------------------------------
> >
> > (Updated Feb. 26, 2013, 2:18 p.m.)
> >
> >
> > Review request for cloudstack.
> >
> >
> > Description
> > -------
> >
> > CLOUDSTACK-420: listZones missing name parameter
> >
> > When calling the listZones API command, you can now supply a name to
> pull a specific zone by name.
> >
> > Updated two classes to include name paramater and query data
> centers/zones by name if suppled:
> > - server/src/com/cloud/api/query/QueryManagerImpl.java
> > -
> api/src/org/apache/cloudstack/api/command/user/zone/ListZonesByCmd.ja
> va
> >
> >
> > This addresses bug CLOUDSTACK-420.
> >
> >
> > Diffs
> > -----
> >
> >
> api/src/org/apache/cloudstack/api/command/user/zone/ListZonesByCmd.ja
> va 97fe2ffeb909e8cd5f985b5bf9f5276c67354110
> > server/src/com/cloud/api/query/QueryManagerImpl.java
> 51312a60eb1c5b6b7a988d072731e3735765260c
> >
> > Diff: https://reviews.apache.org/r/9590/diff/
> >
> >
> > Testing
> > -------
> >
> > Verified on DevCloud running 4.1
> >
> >
> > Thanks,
> >
> > David Grizzanti
> >
> >
Re: Review Request: CLOUDSTACK-420: listZones missing name parameter
Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9590/#review17141
-----------------------------------------------------------
Ship it!
Merged after testing with cloudmonkey+devcloud. Thanks for the patch. Do consider using git format-patch for reviewboard so we can attribute author information easily.
53b6ba379899985ee1a40ade1aca7a1e9777ff71 (master)
2fc5a3ca5e1539ef42b92c59fb0e42e1c6c73bc5 (4.1)
- Prasanna Santhanam
On Feb. 26, 2013, 2:18 p.m., David Grizzanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9590/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2013, 2:18 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> CLOUDSTACK-420: listZones missing name parameter
>
> When calling the listZones API command, you can now supply a name to pull a specific zone by name.
>
> Updated two classes to include name paramater and query data centers/zones by name if suppled:
> - server/src/com/cloud/api/query/QueryManagerImpl.java
> - api/src/org/apache/cloudstack/api/command/user/zone/ListZonesByCmd.java
>
>
> This addresses bug CLOUDSTACK-420.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/zone/ListZonesByCmd.java 97fe2ffeb909e8cd5f985b5bf9f5276c67354110
> server/src/com/cloud/api/query/QueryManagerImpl.java 51312a60eb1c5b6b7a988d072731e3735765260c
>
> Diff: https://reviews.apache.org/r/9590/diff/
>
>
> Testing
> -------
>
> Verified on DevCloud running 4.1
>
>
> Thanks,
>
> David Grizzanti
>
>
Re: Review Request: CLOUDSTACK-420: listZones missing name parameter
Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9590/#review17098
-----------------------------------------------------------
Changes look good to me .Patch applies cleanly and verified on master .Perhaps someone else in the community might want to have a look at it too .
- Pranav Saxena
On Feb. 26, 2013, 2:18 p.m., David Grizzanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9590/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2013, 2:18 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> CLOUDSTACK-420: listZones missing name parameter
>
> When calling the listZones API command, you can now supply a name to pull a specific zone by name.
>
> Updated two classes to include name paramater and query data centers/zones by name if suppled:
> - server/src/com/cloud/api/query/QueryManagerImpl.java
> - api/src/org/apache/cloudstack/api/command/user/zone/ListZonesByCmd.java
>
>
> This addresses bug CLOUDSTACK-420.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/zone/ListZonesByCmd.java 97fe2ffeb909e8cd5f985b5bf9f5276c67354110
> server/src/com/cloud/api/query/QueryManagerImpl.java 51312a60eb1c5b6b7a988d072731e3735765260c
>
> Diff: https://reviews.apache.org/r/9590/diff/
>
>
> Testing
> -------
>
> Verified on DevCloud running 4.1
>
>
> Thanks,
>
> David Grizzanti
>
>